From 0ec9d664d9318a17adf2d5b602da36c16a14e29e Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Sun, 2 Aug 2020 11:59:07 +0800 Subject: [PATCH 1/2] fix(e2e): shouldn't install webdrivers for unchecked browsers on creation --- packages/@vue/cli/lib/promptModules/e2e.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/@vue/cli/lib/promptModules/e2e.js b/packages/@vue/cli/lib/promptModules/e2e.js index cd7eb2018e..7bbfea7605 100644 --- a/packages/@vue/cli/lib/promptModules/e2e.js +++ b/packages/@vue/cli/lib/promptModules/e2e.js @@ -58,9 +58,13 @@ module.exports = cli => { if (answers.e2e === 'cypress') { options.plugins['@vue/cli-plugin-e2e-cypress'] = {} } else if (answers.e2e === 'nightwatch') { - options.plugins['@vue/cli-plugin-e2e-nightwatch'] = {} + options.plugins['@vue/cli-plugin-e2e-nightwatch'] = { + webdrivers: answers.webdrivers + } } else if (answers.e2e === 'webdriverio') { - options.plugins['@vue/cli-plugin-e2e-webdriverio'] = {} + options.plugins['@vue/cli-plugin-e2e-webdriverio'] = { + webdrivers: answers.webdrivers + } } }) } From 5963e7f4b19017df7f051513b70505df1448d3c6 Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Sun, 2 Aug 2020 13:33:31 +0800 Subject: [PATCH 2/2] test: fix corresponding tests --- packages/@vue/cli/lib/promptModules/__tests__/e2e.spec.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/@vue/cli/lib/promptModules/__tests__/e2e.spec.js b/packages/@vue/cli/lib/promptModules/__tests__/e2e.spec.js index 0e43efad25..4ce1d6fe64 100644 --- a/packages/@vue/cli/lib/promptModules/__tests__/e2e.spec.js +++ b/packages/@vue/cli/lib/promptModules/__tests__/e2e.spec.js @@ -54,7 +54,9 @@ test('nightwatch', async () => { const expectedOptions = { plugins: { - '@vue/cli-plugin-e2e-nightwatch': {} + '@vue/cli-plugin-e2e-nightwatch': { + webdrivers: ['chrome', 'firefox'] + } } } @@ -87,7 +89,9 @@ test('webdriverio', async () => { const expectedOptions = { plugins: { - '@vue/cli-plugin-e2e-webdriverio': {} + '@vue/cli-plugin-e2e-webdriverio': { + webdrivers: ['chrome', 'firefox'] + } } }