From 6d36c3cbffc3c9ccfa5fcbf42e3374c32d62eb16 Mon Sep 17 00:00:00 2001 From: Maurici Abad Gutierrez Date: Sat, 9 Jan 2021 16:42:55 +0100 Subject: [PATCH 1/2] Support svg favicon --- packages/@vue/cli-plugin-pwa/lib/HtmlPwaPlugin.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/@vue/cli-plugin-pwa/lib/HtmlPwaPlugin.js b/packages/@vue/cli-plugin-pwa/lib/HtmlPwaPlugin.js index c49afc256a..8db2759a5d 100644 --- a/packages/@vue/cli-plugin-pwa/lib/HtmlPwaPlugin.js +++ b/packages/@vue/cli-plugin-pwa/lib/HtmlPwaPlugin.js @@ -45,6 +45,7 @@ const defaultManifest = { } const defaultIconPaths = { + faviconSVG: 'img/icons/favicon.svg', favicon32: 'img/icons/favicon-32x32.png', favicon16: 'img/icons/favicon-16x16.png', appleTouchIcon: 'img/icons/apple-touch-icon-152x152.png', @@ -84,6 +85,13 @@ module.exports = class HtmlPwaPlugin { const assetsVersionStr = assetsVersion ? `?v=${assetsVersion}` : '' // Favicons + if (iconPaths.faviconSVG != null) { + data.headTags.push(makeTag('link', { + rel: 'icon', + type: 'image/svg+xml', + href: getTagHref(publicPath, iconPaths.faviconSVG, assetsVersionStr) + })) + } if (iconPaths.favicon32 != null) { data.headTags.push(makeTag('link', { rel: 'icon', From 1fa8ea0f1a08f2732c011b5f075b2f714d0e3966 Mon Sep 17 00:00:00 2001 From: Maurici Abad Gutierrez Date: Sat, 9 Jan 2021 16:49:09 +0100 Subject: [PATCH 2/2] Add default faviconSVG value in the documentation --- packages/@vue/cli-plugin-pwa/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/@vue/cli-plugin-pwa/README.md b/packages/@vue/cli-plugin-pwa/README.md index 4457c4357e..3102dfea75 100644 --- a/packages/@vue/cli-plugin-pwa/README.md +++ b/packages/@vue/cli-plugin-pwa/README.md @@ -96,6 +96,7 @@ file, or the `"vue"` field in `package.json`. ```js { + faviconSVG: 'img/icons/favicon.svg', favicon32: 'img/icons/favicon-32x32.png', favicon16: 'img/icons/favicon-16x16.png', appleTouchIcon: 'img/icons/apple-touch-icon-152x152.png',