Skip to content

Hot Reload does not work with Webpack 4.25.1 #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
inca opened this issue Nov 7, 2018 · 2 comments
Closed

Hot Reload does not work with Webpack 4.25.1 #1425

inca opened this issue Nov 7, 2018 · 2 comments
Assignees

Comments

@inca
Copy link

inca commented Nov 7, 2018

Version

15.4.0

Reproduction link

https://github.com/inca/vue-loader-hmr-issue

Steps to reproduce

  • git clone https://github.com/inca/vue-loader-hmr-issue
  • cd vue-loader-hmr-issue
  • npm install
  • npm run dev
  • go to http://localhost:9000
  • try changing app.vue
  • observe stack overflow error in DevTools

Please find more details in reproduction README.

What is expected?

Website should reload the module without reloading the page

What is actually happening?

Stack overflow error, which prevents hot reload from working.

Note: if hotOnly: true is omitted in webpack , full page reload happens instead which hides the underlying issue.


Versions:

  • Vue: 2.5.17
  • Vue Loader: 15.4.2
  • Vue Template Compiler: 2.5.17
  • Webpack: 4.25.1
  • Webpack Dev Server: 3.1.10
@inca
Copy link
Author

inca commented Nov 11, 2018

Is Webpack 4 not officially supported?

@haoqunjiang
Copy link
Member

webpack/webpack-dev-server#87 (comment)

you shouldn't be doing --hot and new webpack.HotModuleReplacementPlugin() in webpack.config.js > plugins: [] section simultaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants