Skip to content

Error when opening with a encoded hash title #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SCWR opened this issue Oct 21, 2020 · 1 comment
Closed

Error when opening with a encoded hash title #3354

SCWR opened this issue Oct 21, 2020 · 1 comment

Comments

@SCWR
Copy link

SCWR commented Oct 21, 2020

Version

3.4.7

Reproduction link

vuejs/vuepress#2599

Steps to reproduce

The final wrong position is

https://github.com/vuepress/vuepress-plugin-smooth-scroll/blob/master/src/enhanceApp.ts#L16

vuepress-plugin-smooth-scroll

This document is used here.

https://router.vuejs.org/guide/advanced/scroll-behavior.html#async-scrolling

There was no problem before because the to.hash returned by vue-router was call decodeURIComponent.

Since version 3.4.3, the uncoded hash has been returned directly.

What is expected?

The scroll was successful.

What is actually happening?

Scrolling failed.

@posva
Copy link
Member

posva commented Oct 21, 2020

Please open a new issue once you boil down the reproduction to only vue router to make sure it comes from vue router

@posva posva closed this as completed Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants