Skip to content

Flaky error handling test #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iurisilvio opened this issue Feb 5, 2022 · 1 comment
Closed

Flaky error handling test #3714

iurisilvio opened this issue Feb 5, 2022 · 1 comment

Comments

@iurisilvio
Copy link
Contributor

Version

3.5.3

Reproduction link

app.circleci.com

Steps to reproduce

Test error handling async component errors fails because NODE_ENV is not defined in the test file and use last definition. It fails depending on tests ordering.

https://app.circleci.com/pipelines/github/vuejs/vue-router/545/workflows/5f905817-db7d-437a-af9f-fc7c2b1561f2/jobs/7431

What is expected?

Tests always passing.

What is actually happening?

Test failing when I add new tests. I think it changes ordering.
@iurisilvio
Copy link
Contributor Author

#3712 fix this issue.

@iurisilvio iurisilvio mentioned this issue Feb 5, 2022
Closed
@posva posva closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iurisilvio @posva