Skip to content

Commit 3d44937

Browse files
andrew-humuyyx990803
authored andcommitted
fix(v-model): properly handle multiline v-model expressions (#9184)
fix #9183
1 parent d780dd2 commit 3d44937

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

src/compiler/directives/model.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export function genComponentModel (
2525

2626
el.model = {
2727
value: `(${value})`,
28-
expression: `"${value}"`,
28+
expression: JSON.stringify(value),
2929
callback: `function (${baseValueExpression}) {${assignment}}`
3030
}
3131
}

test/unit/modules/compiler/codegen.spec.js

+21
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,27 @@ describe('codegen', () => {
151151
)
152152
})
153153

154+
it('generate v-model directive', () => {
155+
assertCodegen(
156+
'<input v-model="test">',
157+
`with(this){return _c('input',{directives:[{name:"model",rawName:"v-model",value:(test),expression:"test"}],domProps:{"value":(test)},on:{"input":function($event){if($event.target.composing)return;test=$event.target.value}}})}`
158+
)
159+
})
160+
161+
it('generate multiline v-model directive', () => {
162+
assertCodegen(
163+
'<input v-model="\n test \n">',
164+
`with(this){return _c('input',{directives:[{name:"model",rawName:"v-model",value:(\n test \n),expression:"\\n test \\n"}],domProps:{"value":(\n test \n)},on:{"input":function($event){if($event.target.composing)return;\n test \n=$event.target.value}}})}`
165+
)
166+
})
167+
168+
it('generate multiline v-model directive on custom component', () => {
169+
assertCodegen(
170+
'<my-component v-model="\n test \n" />',
171+
`with(this){return _c('my-component',{model:{value:(\n test \n),callback:function ($$v) {\n test \n=$$v},expression:"\\n test \\n"}})}`
172+
)
173+
})
174+
154175
it('generate template tag', () => {
155176
assertCodegen(
156177
'<div><template><p>{{hello}}</p></template></div>',

0 commit comments

Comments
 (0)