refactor: set should return early if original def has getter but no setter (#7981)

HcySunYang · yyx990803 · commit 6e5909869c0f · 2018-10-22T16:04:06.000-04:00
diff --git a/src/core/observer/index.js b/src/core/observer/index.js
@@ -179,6 +179,8 @@ export function defineReactive (
       if (process.env.NODE_ENV !== 'production' && customSetter) {
         customSetter()
       }
+      // #7981: for accessor properties without setter
+      if (getter && !setter) return
       if (setter) {
         setter.call(obj, newVal)
       } else {

Original file line number	Diff line number	Diff line change
`@@ -179,6 +179,8 @@ export function defineReactive (`
`179`	`179`	`if (process.env.NODE_ENV !== 'production' && customSetter) {`
`180`	`180`	`customSetter()`
`181`	`181`	`}`
	`182`	`+ // #7981: for accessor properties without setter`
	`183`	`+ if (getter && !setter) return`
`182`	`184`	`if (setter) {`
`183`	`185`	`setter.call(obj, newVal)`
`184`	`186`	`} else {`