fix: avoid logging same error twice when thrown by user in global handler

yyx990803 · yyx990803 · commit ca57920edb56 · 2019-02-07T10:17:28.000-05:00
fix #9445
diff --git a/src/core/util/error.js b/src/core/util/error.js
@@ -49,7 +49,11 @@ function globalHandleError (err, vm, info) {
     try {
       return config.errorHandler.call(null, err, vm, info)
     } catch (e) {
-      logError(e, null, 'config.errorHandler')
+      // if the user intentionally throws the original error in the handler,
+      // do not log it twice
+      if (e !== err) {
+        logError(e, null, 'config.errorHandler')
+      }
     }
   }
   logError(err, vm, info)

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,11 @@ function globalHandleError (err, vm, info) {`
`49`	`49`	`try {`
`50`	`50`	`return config.errorHandler.call(null, err, vm, info)`
`51`	`51`	`} catch (e) {`
`52`		`- logError(e, null, 'config.errorHandler')`
	`52`	`+ // if the user intentionally throws the original error in the handler,`
	`53`	`+ // do not log it twice`
	`54`	`+ if (e !== err) {`
	`55`	`+ logError(e, null, 'config.errorHandler')`
	`56`	`+ }`
`53`	`57`	`}`
`54`	`58`	`}`
`55`	`59`	`logError(err, vm, info)`