Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click handlers do not work on all UXP applications #10306

Closed
g4jc opened this issue Jul 24, 2019 · 3 comments
Closed

Click handlers do not work on all UXP applications #10306

g4jc opened this issue Jul 24, 2019 · 3 comments

Comments

@g4jc
Copy link

g4jc commented Jul 24, 2019

Version

2.6.10

Reproduction link

https://jsfiddle.net/pzumygcq/

Steps to reproduce

  • Download and install any UXP application (Pale Moon, Basilisk, and others).
  • Click on show button (this is important, click handlers work if they are bound when currentFlushTimestamp is 0).
  • This will show a second button, this button will increment the count variable every time it is clicked, except for UXP applications.

What is expected?

count variable will increment

What is actually happening?

Click handler is not firing.


Several sites in production are not working properly on Pale Moon, and by extension, all other applications currently being built on the Unified XUL Platform.

I was able to trace this issue back to #9446. Since the string hack only identifies the FireFox Useragent it does not properly send UXP applications down the correct path.

Short-term, Goanna could be used as an identifier which will work for Pale Moon and Basilisk. However, a better implementation would be to test if the event.timeStamp is returning the correct values, if yes proceed, if note continue down the FF52 path that was introduced as a bug fix in Issue #9446.

Since multiple applications are using UXP, Goanna is not a consistent identifier aside from Pale Moon and Basilisk.

@posva
Copy link
Member

posva commented Jul 24, 2019

The reason we introduced that fix is because it was on an outdated version of FF that was in our range of supported browsers. Pale Moon isn't (this is also the first time I ever see this project) and the timeStamp bug should be fixed in the browser. That being said, if someone is up to contribute a fix by using the user agent for it, they can submit a PR

@posva
Copy link
Member

posva commented Aug 7, 2019

Closing as this seems to be fixed in dev: gamejolt/issue-tracker#1316 (comment)

@posva posva closed this as completed Aug 7, 2019
@g4jc
Copy link
Author

g4jc commented Aug 10, 2019

Yes, this issue was resolved in Vue.js =>2.6.4. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants