Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrary Code Injection In "serialize-javascript" For "vue-server-renderer" #11427

Closed
dargmuesli opened this issue Jun 2, 2020 · 5 comments
Closed

Arbitrary Code Injection In "serialize-javascript" For "vue-server-renderer" #11427

dargmuesli opened this issue Jun 2, 2020 · 5 comments

Comments

@dargmuesli
Copy link

Version

2.6.11

Reproduction link

https://app.snyk.io/vuln/SNYK-JS-SERIALIZEJAVASCRIPT-570062

Steps to reproduce

n/a

What is expected?

Remediation
Upgrade serialize-javascript to version 3.1.0 or higher.

What is actually happening?

n/a
@posva
Copy link
Member

posva commented Jun 2, 2020

Thanks but this Is a dev dependency

@posva posva closed this as completed Jun 2, 2020
@dargmuesli
Copy link
Author

It's listed under dependencies though:

vue/packages/vue-server-renderer/package.json

Line 28 in fb589e6

"serialize-javascript": "^2.1.2",
🤔

@dargmuesli
Copy link
Author

I'm not talking about vue, I'm talking about vue-server-renderer^^

@posva posva mentioned this issue Jun 3, 2020
Merged
13 tasks
@posva
Copy link
Member

posva commented Jun 3, 2020

I see, thanks, now it makes more sense. I opened #11434
It wasn't clear from such a short robotic issue with so many n/a 😄

@dargmuesli
Copy link
Author

I thought the title was large enough, sorry 😄

@posva posva mentioned this issue Aug 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@posva @dargmuesli