Skip to content

Commit ef1f79d

Browse files
committed
chore: done todes
1 parent 1676e5e commit ef1f79d

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

Diff for: src/firestore/index.ts

-2
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,6 @@ interface BindCollectionParameter extends CommonBindOptionsParameter {
187187
collection: CollectionReference | Query
188188
}
189189

190-
// TODO: refactor without using an object to improve size like the other functions
191-
192190
export function bindCollection<T>(
193191
target: BindCollectionParameter['target'],
194192
collection: CollectionReference<T> | Query<T>,

Diff for: src/vuefire/firestore.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -304,8 +304,7 @@ export interface UseCollectionOptions {}
304304
* @returns
305305
*/
306306
export function useCollection<
307-
// explicit generic as unknown to allow arbitrary types
308-
// TODO: check if it's actually possible to use something like `number` as the generic, if not, remove these constrains
307+
// explicit generic as unknown to allow arbitrary types like numbers or strings
309308
R extends CollectionReference<unknown> | Query<unknown>
310309
>(
311310
collectionRef: R,

0 commit comments

Comments
 (0)