Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utils.ts #1223

Closed
wants to merge 4 commits into from
Closed

Update utils.ts #1223

wants to merge 4 commits into from

Conversation

donatas-luciunas
Copy link

@donatas-luciunas donatas-luciunas commented Feb 6, 2022

Works incorrectly with { somethingRef: null } → { somethingRef: 'something/longId' }

donatas-luciunas and others added 4 commits February 6, 2022 12:45
Works incorrectly with { collection: [{ ref: null }] } → { collection: [{ ref: 'something/longId' }] }
@donatas-luciunas
Copy link
Author

donatas-luciunas commented Feb 12, 2022

@posva bug reproduction https://github.com/donatas-luciunas/vuefire-bug
Also added fixed branch

@donatas-luciunas
Copy link
Author

@posva could you please merge the bugfix?

@donatas-luciunas
Copy link
Author

ping @posva

@posva
Copy link
Member

posva commented Jun 15, 2022

@donatas-luciunas stop the pinging, I will take a look when I have time. Thanks.

@posva posva closed this Nov 18, 2022
@posva posva reopened this Nov 18, 2022
@posva posva closed this in 1d46371 Dec 19, 2022
@posva
Copy link
Member

posva commented Dec 19, 2022

Thanks! The fix ended up being a little bit different

@donatas-luciunas donatas-luciunas deleted the patch-1 branch December 19, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants