fix: siteConfig.chainWebpack was executed twice.

ulivz · ulivz · commit 0d45cf4de7ae · 2018-11-18T01:47:26.000+08:00
diff --git a/packages/@vuepress/core/lib/webpack/createClientConfig.js b/packages/@vuepress/core/lib/webpack/createClientConfig.js
@@ -67,10 +67,6 @@ module.exports = function createClientConfig (ctx) {
       }])
   }
 
-  if (ctx.siteConfig.chainWebpack) {
-    ctx.siteConfig.chainWebpack(config, false /* isServer */)
-  }
-
   ctx.pluginAPI.options.chainWebpack.syncApply(config, false /* isServer */)
 
   return config
diff --git a/packages/@vuepress/core/lib/webpack/createServerConfig.js b/packages/@vuepress/core/lib/webpack/createServerConfig.js
@@ -56,10 +56,6 @@ module.exports = function createServerConfig (ctx) {
       }])
   }
 
-  if (ctx.siteConfig.chainWebpack) {
-    ctx.siteConfig.chainWebpack(config, true /* isServer */)
-  }
-
   ctx.pluginAPI.options.chainWebpack.syncApply(config, true /* isServer */)
 
   return config

Original file line number	Diff line number	Diff line change
`@@ -67,10 +67,6 @@ module.exports = function createClientConfig (ctx) {`
`67`	`67`	`}])`
`68`	`68`	`}`
`69`	`69`
`70`		`- if (ctx.siteConfig.chainWebpack) {`
`71`		`- ctx.siteConfig.chainWebpack(config, false /* isServer */)`
`72`		`- }`
`73`		`-`
`74`	`70`	`ctx.pluginAPI.options.chainWebpack.syncApply(config, false /* isServer */)`
`75`	`71`
`76`	`72`	`return config`
Original file line number	Diff line number	Diff line change
`@@ -56,10 +56,6 @@ module.exports = function createServerConfig (ctx) {`
`56`	`56`	`}])`
`57`	`57`	`}`
`58`	`58`
`59`		`- if (ctx.siteConfig.chainWebpack) {`
`60`		`- ctx.siteConfig.chainWebpack(config, true /* isServer */)`
`61`		`- }`
`62`		`-`
`63`	`59`	`ctx.pluginAPI.options.chainWebpack.syncApply(config, true /* isServer */)`
`64`	`60`
`65`	`61`	`return config`