lint

Author: yyx990803

.eslintrc.js

@@ -1,4 +1,7 @@
 module.exports = {
   root: true,
-  extends: ['plugin:vue-libs/recommended']
+  extends: ['plugin:vue-libs/recommended'],
+  rules: {
+    indent: ['error', 2, { MemberExpression: 'off' }]
+  }
 }

lib/app/Content.js

@@ -17,9 +17,9 @@ export default {
     const componentName = this.$page.path === '/'
       ? 'index'
       : this.$page.path
-          .replace(/^\//, '')
-          .replace(/\.html$/, '')
-          .replace(/\//g, '-')
+        .replace(/^\//, '')
+        .replace(/\.html$/, '')
+        .replace(/\//g, '-')
     return h('page-' + componentName)
   }
 }
@@ -34,9 +34,7 @@ function getTitle (vm) {
     ? selfTitle
       ? (siteTitle + ' | ' + selfTitle)
       : siteTitle
-    : selfTitle
-      ? selfTitle
-      : 'VuePress'
+    : selfTitle || 'VuePress'
 }
 
 function getLang (vm) {

lib/build.js

@@ -54,7 +54,7 @@ module.exports = async function build (sourceDir, cliOptions = {}) {
 
   // if the user does not have a custom 404.md, generate the theme's default
   if (!options.siteData.pages.some(p => p.path === '/404.html')) {
-    await renderPage({ path: '/404.html'})
+    await renderPage({ path: '/404.html' })
   }
 
   // DONE.

lib/markdown/highlight.js

@@ -10,11 +10,10 @@ module.exports = (str, lang) => {
       loadLanguages([lang])
     } catch (e) {
       throw new Error(`[vuepress] Syntax highlight for language "${lang}" is not supported.`)
-      return ''
     }
   }
   if (prism.languages[lang]) {
-    let res = prism.highlight(str, prism.languages[lang], lang)
+    const res = prism.highlight(str, prism.languages[lang], lang)
     return `<pre class="language-${lang}"><code v-pre>${res}</code></pre>`
   }
   return ''

lib/markdown/index.js

@@ -14,10 +14,10 @@ module.exports = ({ markdown = {}}) => {
     typographer: true,
     highlight
   })
-  .use(convertRouterLink)
-  .use(anchor, Object.assign({ permalink: true, permalinkBefore: true }, markdown.anchor))
-  .use(toc, Object.assign({ includeLevel: [2, 3] }, markdown.toc))
-  .use(container, 'tip')
-  .use(container, 'warning')
-  .use(container, 'danger')
+    .use(convertRouterLink)
+    .use(anchor, Object.assign({ permalink: true, permalinkBefore: true }, markdown.anchor))
+    .use(toc, Object.assign({ includeLevel: [2, 3] }, markdown.toc))
+    .use(container, 'tip')
+    .use(container, 'warning')
+    .use(container, 'danger')
 }

lib/webpack/markdownLoader.js

@@ -3,7 +3,6 @@ const frontmatter = require('yaml-front-matter')
 
 module.exports = function (src) {
   const { markdown } = getOptions(this)
-  currentFile = this.resourcePath
   const content = frontmatter.loadFront(src).__content
   const html = markdown.render(content)
   return `<template><div class="markdown">${html}</div></template>`

lib/webpack/serverConfig.js

@@ -3,7 +3,6 @@ module.exports = function createServerConfig (options) {
   const path = require('path')
   const WebpackBar = require('webpackbar')
   const createBaseConfig = require('./baseConfig')
-  const nodeExternals = require('webpack-node-externals')
   const VueSSRServerPlugin = require('vue-server-renderer/server-plugin')
   const CopyPlugin = require('copy-webpack-plugin')
 

package.json

@@ -8,7 +8,8 @@
   },
   "scripts": {
     "dev": "node bin/vuepress dev docs",
-    "build": "node bin/vuepress build docs"
+    "build": "node bin/vuepress build docs",
+    "lint": "eslint bin lib test"
   },
   "repository": {
     "type": "git",
@@ -74,7 +75,6 @@
     "vue-template-compiler": "^2.5.16",
     "webpack": "^4.4.1",
     "webpack-chain": "^4.5.0",
-    "webpack-node-externals": "^1.7.2",
     "webpack-serve": "^0.3.1",
     "webpackbar": "^2.6.1",
     "yaml-front-matter": "^4.0.0"

yarn.lock

@@ -5866,10 +5866,6 @@ webpack-log@^1.0.1, webpack-log@^1.1.1, webpack-log@^1.1.2:
     loglevelnext "^1.0.1"
     uuid "^3.1.0"
 
-webpack-node-externals@^1.7.2:
-  version "1.7.2"
-  resolved "https://registry.yarnpkg.com/webpack-node-externals/-/webpack-node-externals-1.7.2.tgz#6e1ee79ac67c070402ba700ef033a9b8d52ac4e3"
-
 webpack-serve@^0.3.1:
   version "0.3.1"
   resolved "https://registry.yarnpkg.com/webpack-serve/-/webpack-serve-0.3.1.tgz#a91a99d013a70d2c15df2d12c5d31a8842c033ba"