Skip to content

Commit 795c230

Browse files
authored
refactor($core): catch initial push to avoid warning (#2629)
1 parent 4268c79 commit 795c230

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

Diff for: packages/@vuepress/core/lib/client/serverEntry.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ export default context => new Promise((resolve, reject) => {
99
return reject({ url: fullPath })
1010
}
1111

12-
router.push(url)
13-
router.onReady(() => resolve(app))
12+
// error handled in onReady
13+
router.push(url).catch(() => {})
14+
router.onReady(() => resolve(app), reject)
1415
})
1516
})

Diff for: packages/@vuepress/core/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"url-loader": "^1.0.1",
5252
"vue": "^2.6.10",
5353
"vue-loader": "^15.7.1",
54-
"vue-router": "^3.1.3",
54+
"vue-router": "^3.4.5",
5555
"vue-server-renderer": "^2.6.10",
5656
"vue-template-compiler": "^2.6.10",
5757
"vuepress-html-webpack-plugin": "^3.2.0",

Diff for: yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -13715,10 +13715,10 @@ vue-loader@^15.7.1:
1371513715
vue-hot-reload-api "^2.3.0"
1371613716
vue-style-loader "^4.1.0"
1371713717

13718-
vue-router@^3.1.3:
13719-
version "3.1.3"
13720-
resolved "https://registry.yarnpkg.com/vue-router/-/vue-router-3.1.3.tgz#e6b14fabc0c0ee9fda0e2cbbda74b350e28e412b"
13721-
integrity sha512-8iSa4mGNXBjyuSZFCCO4fiKfvzqk+mhL0lnKuGcQtO1eoj8nq3CmbEG8FwK5QqoqwDgsjsf1GDuisDX4cdb/aQ==
13718+
vue-router@^3.4.5:
13719+
version "3.4.5"
13720+
resolved "https://registry.yarnpkg.com/vue-router/-/vue-router-3.4.5.tgz#d396ec037b35931bdd1e9b7edd86f9788dc15175"
13721+
integrity sha512-ioRY5QyDpXM9TDjOX6hX79gtaMXSVDDzSlbIlyAmbHNteIL81WIVB2e+jbzV23vzxtoV0krdS2XHm+GxFg+Nxg==
1372213722

1372313723
vue-server-renderer@^2.6.10:
1372413724
version "2.6.10"

0 commit comments

Comments
 (0)