Skip to content

Commit f2a8229

Browse files
FadySamirSadekyyx990803
authored andcommitted
fix(dev build): use portfinder (#30)
close #26
1 parent be0aa9f commit f2a8229

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed

lib/dev.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ module.exports = async function dev (sourceDir, cliOptions = {}) {
1010
const serveStatic = require('koa-static')
1111
const HTMLPlugin = require('html-webpack-plugin')
1212
const history = require('connect-history-api-fallback')
13+
const portfinder = require('portfinder')
1314

1415
const prepare = require('./prepare')
1516
const HeadPlugin = require('./webpack/HeadPlugin')
@@ -71,7 +72,8 @@ module.exports = async function dev (sourceDir, cliOptions = {}) {
7172
}
7273

7374
const compiler = webpack(config)
74-
const port = cliOptions.port || options.siteConfig.port || 8080
75+
portfinder.basePort = cliOptions.port || options.siteConfig.port || 8080
76+
const port = await portfinder.getPortPromise()
7577

7678
let isFirst = true
7779
compiler.hooks.done.tap('vuepress', () => {

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@
7070
"nprogress": "^0.2.0",
7171
"object-assign": "^4.1.1",
7272
"optimize-css-assets-webpack-plugin": "^4.0.0",
73+
"portfinder": "^1.0.13",
7374
"postcss-loader": "^2.1.3",
7475
"prismjs": "^1.13.0",
7576
"register-service-worker": "^1.2.0",

yarn.lock

+12
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,10 @@ async-limiter@~1.0.0:
298298
version "1.0.0"
299299
resolved "https://registry.yarnpkg.com/async-limiter/-/async-limiter-1.0.0.tgz#78faed8c3d074ab81f22b4e985d79e8738f720f8"
300300

301+
async@^1.5.2:
302+
version "1.5.2"
303+
resolved "https://registry.yarnpkg.com/async/-/async-1.5.2.tgz#ec6a61ae56480c0c3cb241c95618e20892f9672a"
304+
301305
asynckit@^0.4.0:
302306
version "0.4.0"
303307
resolved "https://registry.yarnpkg.com/asynckit/-/asynckit-0.4.0.tgz#c79ed97f7f34cb8f2ba1bc9790bcc366474b4b79"
@@ -4229,6 +4233,14 @@ pn@^1.1.0:
42294233
version "1.1.0"
42304234
resolved "https://registry.yarnpkg.com/pn/-/pn-1.1.0.tgz#e2f4cef0e219f463c179ab37463e4e1ecdccbafb"
42314235

4236+
portfinder@^1.0.13:
4237+
version "1.0.13"
4238+
resolved "https://registry.yarnpkg.com/portfinder/-/portfinder-1.0.13.tgz#bb32ecd87c27104ae6ee44b5a3ccbf0ebb1aede9"
4239+
dependencies:
4240+
async "^1.5.2"
4241+
debug "^2.2.0"
4242+
mkdirp "0.5.x"
4243+
42324244
posix-character-classes@^0.1.0:
42334245
version "0.1.1"
42344246
resolved "https://registry.yarnpkg.com/posix-character-classes/-/posix-character-classes-0.1.1.tgz#01eac0fe3b5af71a2a6c02feabb8c1fef7e00eab"

0 commit comments

Comments
 (0)