Skip to content

Improve CircleCI workflow #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kefranabg opened this issue Aug 6, 2019 · 0 comments · Fixed by #1759
Closed

Improve CircleCI workflow #1748

kefranabg opened this issue Aug 6, 2019 · 0 comments · Fixed by #1759
Assignees
Labels
type: enhancement Request to enhance an existing feature

Comments

@kefranabg
Copy link
Collaborator

kefranabg commented Aug 6, 2019

Feature request

I've noticed that some improvements could be added to the CI process:

  • Split the single main process into multiple jobs.
    Why ?

    • From a github PR, it would be easier to understand what's wrong when CI fails.
      We'd have this:
      Sans titre

      Instead of this:
      Capture d’écran 2019-08-06 à 11 06 43

    • Ci process would be faster because we could parallelize some jobs.

  • Saving cache should rely on yarn.lock checksum instead of package.json.

  • We should use --frozen-lockfile flag when installing deps with yarn (on CI).

  • Current docker image is circleci/node:10.15.2 but I think we should use circleci/node:latest as I don't see any compatibility note telling that we shouldn't use latest versions of node 🙂

  • Current lint command fix errors (so it never fails). The CI process should never change source code. CI lint command has to be replaced by a lint:check that just check if code is correctly formatted and exit with error code if necessary.

Are you willing to work on this yourself?

Yes 👍I'm on vacation for the moment, but I'll do it as soon as I get back 🏖

@kefranabg kefranabg added the type: enhancement Request to enhance an existing feature label Aug 6, 2019
@kefranabg kefranabg self-assigned this Aug 6, 2019
@kefranabg kefranabg mentioned this issue Aug 8, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Request to enhance an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant