Skip to content

Update Semantic Pull Request check configuration #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kefranabg opened this issue Sep 11, 2019 · 4 comments · Fixed by #1853
Closed

Update Semantic Pull Request check configuration #1850

kefranabg opened this issue Sep 11, 2019 · 4 comments · Fixed by #1853
Assignees
@kefranabg
Labels
complexity: easy Easy complexity effort: low Around a day or less type: feature request Request to add a new feature version: 1.x Relates to version 1 of VuePress

Comments

@kefranabg
Copy link
Collaborator

We should disable the commit name check and just keep the PR title check.

This is ok if we consider that we're supposed to rename the PR title and use the "squash and merge" feature. This would be far easier for us to handle this Semantic Pull Request check.
@kefranabg kefranabg added type: feature request Request to add a new feature version: 1.x Relates to version 1 of VuePress complexity: easy Easy complexity effort: low Around a day or less labels Sep 11, 2019
@kefranabg kefranabg self-assigned this Sep 11, 2019
@flozero
Copy link
Collaborator

flozero commented Sep 12, 2019

The best could be to just allow squash merging on master. It is possible no ?

@kefranabg
Copy link
Collaborator Author

kefranabg commented Sep 12, 2019 •
edited
Loading

This is already available:

Capture d’écran 2019-09-12 à 09 37 42

But the problem is the Github check, not the way we merge branch

@flozero
Copy link
Collaborator

flozero commented Sep 12, 2019 •
edited
Loading

Yeah but you can limit to it no ? But yeah you right

@kefranabg
Copy link
Collaborator Author

Oh! Actually that's a good idea! Yes it's possible but @ulivz is the only one that can access the repos settings to do that

@kefranabg kefranabg mentioned this issue Sep 12, 2019
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kefranabg kefranabg

Labels
complexity: easy Easy complexity effort: low Around a day or less type: feature request Request to add a new feature version: 1.x Relates to version 1 of VuePress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix($semantic-config): Check title only for PRs vuejs/vuepress
2 participants
@kefranabg @flozero