Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open a PR on Wappalyzer to detect VuePress sites #1992

Closed
kefranabg opened this issue Oct 31, 2019 · 13 comments · Fixed by #2133
Closed

Open a PR on Wappalyzer to detect VuePress sites #1992

kefranabg opened this issue Oct 31, 2019 · 13 comments · Fixed by #2133
Assignees
Labels
complexity: easy Easy complexity contribution welcome Contributions welcome status: community assigned Community assigned type: feature request Request to add a new feature

Comments

@kefranabg
Copy link
Collaborator

Feature request

Open a PR to Wappalyzer chrome extension so it can detect VuePress sites.

Are you willing to work on this yourself?

Yes

@kefranabg kefranabg added type: feature request Request to add a new feature status: core team assigned Core team member assigned labels Oct 31, 2019
@kefranabg kefranabg assigned kefranabg and unassigned kefranabg Oct 31, 2019
@kefranabg kefranabg added complexity: easy Easy complexity contribution welcome Contributions welcome and removed status: core team assigned Core team member assigned labels Nov 6, 2019
@kefranabg
Copy link
Collaborator Author

We can identify a VuePress website by adding a generator meta tag <meta name="generator" content="Vuepress v1.2.0">

@nimitbhargava
Copy link
Contributor

Can I take this up? @kefranabg

@kefranabg
Copy link
Collaborator Author

Sure @nimitbhargava, let me know if you have some questions.

@nimitbhargava
Copy link
Contributor

@kefranabg
I checked https://vuepress.vuejs.org/ but I don't see <meta name="generator" content="Vuepress v1.2.0"> tag there. Is this going to implemented later? 🤔

@kefranabg
Copy link
Collaborator Author

Nope, you have to open a PR in VuePress 😉

@kefranabg kefranabg added the status: community assigned Community assigned label Nov 7, 2019
@nimitbhargava
Copy link
Contributor

Got it. So I will create PR in VuePress and then Wappalyzer 👍

@nimitbhargava
Copy link
Contributor

Shall I use VuePress instead of Vuepress here (<meta name="generator" content="Vuepress v1.2.0">)?

@kefranabg
Copy link
Collaborator Author

I think VuePress is better. I think you can remove the version after VuePress for now.

@nimitbhargava
Copy link
Contributor

Just letting you know, I haven't start this yet. But do plan to 😁
I am currently going through VuePress source code.

@kefranabg
Copy link
Collaborator Author

Hi @nimitbhargava are you still working on this one?

@nimitbhargava
Copy link
Contributor

I got stuck while running VuePress locally.
@kefranabg Is it possible to pair up for sometime?

@kefranabg
Copy link
Collaborator Author

@nimitbhargava sorry for the delay 😅I just made the PR as it was just an html tag to add to the template. see #2133 Hope it's ok for you! Feel free to do a code review if you want to

@JordanPlayz158
Copy link

It seems that the meta tag shows up in page source but not in developer tools unlike the other meta tags (description and theme-color) which is causing Wappalyzer to not detect VuePress as a technology on VuePress sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: easy Easy complexity contribution welcome Contributions welcome status: community assigned Community assigned type: feature request Request to add a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants