Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is slot working in ParentLayout? #2054

Closed
1 task
stardustrain opened this issue Dec 1, 2019 · 5 comments
Closed
1 task

Is slot working in ParentLayout? #2054

stardustrain opened this issue Dec 1, 2019 · 5 comments

Comments

@stardustrain
Copy link

  • I confirm that this is an issue rather than a question.

Bug report

Steps to reproduce

  1. I'd made theme folder at under .vuepress folder.
  2. Make index.js file at under theme folder and write this:
module.exports = {
  extend: '@vuepress/theme-default'
}
  1. And make layouts folder at under .theme, Layout.vue file at layouts folder and write this:
<template>
  <ParentLayout>
    <template #page-bottom>
      <vue-disqus />
    </template>
  </ParentLayout>
</template>

<script>
  import ParentLayout from '@parent-theme/layouts/Layout'

  export default {
    components: {
      ParentLayout,
    },
  }
</script>

What is expected?

I will render disqus component every page.

What is actually happening?

Doesn't render disqus component.

Other relevant information

I'd refereced by https://github.com/vuejs/vuepress/blob/master/packages/%40vuepress/theme-vue/layouts/Layout.vue.

  • Output of npx vuepress info in my VuePress project:

System:
- OS: macOS Mojave 10.14.6
- CPU: (8) x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
Binaries:
- Node: 12.13.0 - ~/.nvm/versions/node/v12.13.0/bin/node
- Yarn: 1.19.1 - /usr/local/bin/yarn
- npm: 6.12.0 - ~/.nvm/versions/node/v12.13.0/bin/npm
Browsers:
- Chrome: 78.0.3904.108
- Firefox: 70.0.1
- Safari: 13.0.3
npmPackages:
- @vuepress/core: 1.2.0
- @vuepress/theme-default: 1.2.0
- vuepress: ^1.2.0 => 1.2.0
npmGlobalPackages:
- vuepress: Not Found

@haoranpb
Copy link
Contributor

haoranpb commented Dec 1, 2019

Hi @stardustrain ,

Thanks for the report. I think it's fixed by #1951 , and hasn't come out yet. Please patiently wait for the next release.

@stardustrain
Copy link
Author

@ludanxer Thank you for your notice! Therefore is it possible to close this issue?

@haoranpb
Copy link
Contributor

haoranpb commented Dec 2, 2019

I'm not sure. You can wait for the core contributors to come across this issue. There are quite a few commits after 1.2.0, maybe it's time for a new release.

@kefranabg
Copy link
Collaborator

The fix will be available in the next release

@AntoineAugusti
Copy link

Hello!

Any way to use the master version with this unreleased fix?

I've tried pulling the master version in package.json with "vuepress": "vuejs/vuepress#master", but the vuepress CLI is unavailable after installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants