Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Highlight current region in sidebar #245

Closed
octref opened this issue Apr 24, 2018 · 7 comments
Closed

Feature Request: Highlight current region in sidebar #245

octref opened this issue Apr 24, 2018 · 7 comments
Labels
contribution welcome Contributions welcome type: feature request Request to add a new feature

Comments

@octref
Copy link
Member

octref commented Apr 24, 2018

This is a great feature I miss from gitbook. It's also on vuejs.org.

Example: try to scroll in this page: https://vue-loader.vuejs.org/guide/pre-processors.html. No updates on sidebar.

image

@yyx990803 yyx990803 added type: feature request Request to add a new feature contribution welcome Contributions welcome labels Apr 24, 2018
@ghost
Copy link

ghost commented Apr 24, 2018

I'd love to grab this one 😄.

@ghost
Copy link

ghost commented Apr 25, 2018

Do you have any suggestions for where this should live? I was thinking about using a scroll event in Layout.vue to change the active class. It would be similar to the approach that vuejs.org uses.

@yyx990803
Copy link
Member

@ryanriv yeah, it can probably live in Layout.vue. Although don't use direct DOM manipulation - you just need to update the hash and the classes will update automatically.

@ulivz
Copy link
Member

ulivz commented Apr 25, 2018

It would be better to add throttle control for the scroll event.

@ghost
Copy link

ghost commented Apr 27, 2018

Thanks for the great suggestions! I have some initial work done on this here #272

@ulivz
Copy link
Member

ulivz commented Apr 27, 2018

@ryanriv Thanks for the great work again. code merged!

@ulivz ulivz closed this as completed Apr 27, 2018
@octref
Copy link
Member Author

octref commented Apr 27, 2018

@ryanriv Thanks again for your work 👍 This is the only missing feature that kept me from jumping on the train :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Contributions welcome type: feature request Request to add a new feature
Projects
None yet
Development

No branches or pull requests

3 participants