Skip to content

Customize the default theme #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mittalyashu opened this issue Jul 1, 2018 · 3 comments
Closed

Customize the default theme #627

mittalyashu opened this issue Jul 1, 2018 · 3 comments

Comments

@mittalyashu
Copy link

mittalyashu commented Jul 1, 2018

Feature request

What problem does this feature solve?

I didn't find any option to add logo/icon to the navbar, so customizing on a new theme is not a good idea, where we have to only add a div.

What does the proposed API look like?

Not sure

How should this be implemented in your opinion?

By adding the option of customizing the default theme.

Are you willing to work on this yourself?

I will try.

@ulivz
Copy link
Member

ulivz commented Jul 1, 2018

Sorry but no. The whole point is the default theme was designed to fit a specific use case and not aiming to be generically extendable. We have no intention to increase the maintenance surface of the default theme. If you have some specific need, you can eject eject or build your own theme.

@ulivz ulivz closed this as completed Jul 1, 2018
@mittalyashu
Copy link
Author

I get that

Note, however, once you eject, you are on your own and won't be receiving future updates or bug fixes to the default theme even if you upgrade VuePress.

But if that's the case, then how can I update the changes that Vuepress will make in the default theme.

@faroit
Copy link

faroit commented Jan 5, 2019

@ulivz did you consider having the default theme as a separate plugin for 1.0 so that ejecting is not necessary anymore but rather allow people to fork the default theme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants