Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

themeConfig.serviceWorker.updatePopup doesn't work #675

Closed
ulivz opened this issue Jul 27, 2018 · 1 comment
Closed

themeConfig.serviceWorker.updatePopup doesn't work #675

ulivz opened this issue Jul 27, 2018 · 1 comment
Assignees
Labels
priority: high High priority issue type: bug Something isn't working

Comments

@ulivz
Copy link
Member

ulivz commented Jul 27, 2018

Bug report

Though I have tested for #533 at pure environment by many times, but for now it truly doesn't work at production, which is a blocker of our next minor release.

Version

0.13.0 Pre-Release

Steps to reproduce

  1. Create a new commit into master
  2. Check out the website, you can find there is a new registered SW which is in waiting, but no any SW-update popup show up.

What is expected?

SW-update popup should be shown.

What is actually happening?

No popup was shown.

Other relevant information

  • Your OS: OSX 10.12.6
  • Node.js version: 9.4.0
  • Browser version: Chrome 67.0.3396.99
  • Is this a global or local install?
  • Which package manager did you use for the install?
@ulivz ulivz added priority: high High priority issue type: bug Something isn't working labels Jul 27, 2018
@ulivz ulivz self-assigned this Jul 27, 2018
@ulivz
Copy link
Member Author

ulivz commented Jul 28, 2018

This isn't a bug of default theme, but a common issue of pure wrapped theme like vuepress-theme-vue.

Transferred to vuepress-theme-vue instead.

@ulivz ulivz closed this as completed Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High priority issue type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant