From 357b0a1456b96518451a56eb8405747d260861b6 Mon Sep 17 00:00:00 2001 From: hello Jun Date: Sat, 6 Jun 2020 17:12:11 +0800 Subject: [PATCH 1/3] Update updateMeta.js fix question that parent node is not `head` when looping `meta` element --- packages/@vuepress/core/lib/client/root-mixins/updateMeta.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/@vuepress/core/lib/client/root-mixins/updateMeta.js b/packages/@vuepress/core/lib/client/root-mixins/updateMeta.js index eb9aebbf22..d9521d89e6 100644 --- a/packages/@vuepress/core/lib/client/root-mixins/updateMeta.js +++ b/packages/@vuepress/core/lib/client/root-mixins/updateMeta.js @@ -62,7 +62,9 @@ export default { function updateMetaTags (newMetaTags, currentMetaTags) { if (currentMetaTags) { [...currentMetaTags].forEach(c => { - document.head.removeChild(c) + const parentIsHead = c.parentNode && + c.parentNode.tagName.toLocaleUpperCase() === 'HEAD' + parentIsHead && document.head.removeChild(c) }) } if (newMetaTags) { From 942eb58ca412d8cab8eedc062e6b45ca5de60a3c Mon Sep 17 00:00:00 2001 From: hello Jun Date: Sat, 6 Jun 2020 17:39:35 +0800 Subject: [PATCH 2/3] Update updateMeta.js fix: question that parent node is not `head` when looping `meta` element --- packages/@vuepress/core/lib/client/root-mixins/updateMeta.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/@vuepress/core/lib/client/root-mixins/updateMeta.js b/packages/@vuepress/core/lib/client/root-mixins/updateMeta.js index d9521d89e6..7b95c026d7 100644 --- a/packages/@vuepress/core/lib/client/root-mixins/updateMeta.js +++ b/packages/@vuepress/core/lib/client/root-mixins/updateMeta.js @@ -62,8 +62,8 @@ export default { function updateMetaTags (newMetaTags, currentMetaTags) { if (currentMetaTags) { [...currentMetaTags].forEach(c => { - const parentIsHead = c.parentNode && - c.parentNode.tagName.toLocaleUpperCase() === 'HEAD' + const parentIsHead = c.parentNode + && c.parentNode.tagName.toLocaleUpperCase() === 'HEAD' parentIsHead && document.head.removeChild(c) }) } From becf44ac73efc27957fca0b46e4ee1019648112f Mon Sep 17 00:00:00 2001 From: hello Jun Date: Sat, 6 Jun 2020 17:48:55 +0800 Subject: [PATCH 3/3] Update updateMeta.js format documents --- packages/@vuepress/core/lib/client/root-mixins/updateMeta.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@vuepress/core/lib/client/root-mixins/updateMeta.js b/packages/@vuepress/core/lib/client/root-mixins/updateMeta.js index 7b95c026d7..c5a14a5ba4 100644 --- a/packages/@vuepress/core/lib/client/root-mixins/updateMeta.js +++ b/packages/@vuepress/core/lib/client/root-mixins/updateMeta.js @@ -62,7 +62,7 @@ export default { function updateMetaTags (newMetaTags, currentMetaTags) { if (currentMetaTags) { [...currentMetaTags].forEach(c => { - const parentIsHead = c.parentNode + const parentIsHead = c.parentNode && c.parentNode.tagName.toLocaleUpperCase() === 'HEAD' parentIsHead && document.head.removeChild(c) })