Skip to content

Commit a7e282c

Browse files
tasksetKAGA-KOKO
authored andcommitted
tick/rcu: Fix bogus ratelimit condition
The ratelimit logic in report_idle_softirq() is broken because the exit condition is always true: static int ratelimit; if (ratelimit < 10) return false; ---> always returns here ratelimit++; ---> no chance to run Make it check for >= 10 instead. Fixes: 0345691 ("tick/rcu: Stop allowing RCU_SOFTIRQ in idle") Signed-off-by: Wen Yang <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent fc4b4d9 commit a7e282c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/time/tick-sched.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1030,7 +1030,7 @@ static bool report_idle_softirq(void)
10301030
return false;
10311031
}
10321032

1033-
if (ratelimit < 10)
1033+
if (ratelimit >= 10)
10341034
return false;
10351035

10361036
/* On RT, softirqs handling may be waiting on some lock */

0 commit comments

Comments
 (0)