Skip to content

Tests t0112 and t0113 use 1.1-specific features #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

gkellogg
Copy link
Member

and should have specVersion: 1.1 to not interfer with 1.0 development.

Fixes #649.

…Version: 1.1` to not interfer with 1.0 development.

Fixes #649.
@gkellogg gkellogg moved this to Testing in JSON-LD Management Apr 22, 2025
@gkellogg gkellogg moved this from Testing to PRs in JSON-LD Management Apr 23, 2025
@gkellogg gkellogg merged commit c6657bf into main Jun 4, 2025
1 check passed
@gkellogg gkellogg deleted the compaction-tests-1-1-only branch June 4, 2025 16:24
Copy link
Contributor

@niklasl niklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w3cbot
Copy link

w3cbot commented Jun 4, 2025

This was discussed during the #json-ld meeting on 04 June 2025.

View the transcript

w3c/json-ld-api#655

<gb> Pull Request 655 Tests t0112 and t0113 use 1.1-specific features (by gkellogg) [test:missing-coverage]

gkellogg: this one was based upon an inbound issue

w3c/json-ld-api#655
… whether or not `@graph` is necessary at some point
… these are related to 1.1 features which are meant to be tested against 1.0 and 1.1 implementations
… this change prevents them running against 1.0 implementations

bigbluehat: and look! there's that change again

pchampin: yeah. that's it.

gkellogg: it changed the `fromRDF-manifest.html`
… there must have been a change to the turtle manifest
… the issue is because the bot is not able to push commits to external repositories
… the purpose of the bot is to update all the things related to changes to the turtle manifest
… but if a change is made outside a branch, then the bot will not do it's work
… it should be a self correcting issue
… if we wanted to be clever, we could have a bot check all the manifests for consistency
… but the system will eventually stabalize

bigbluehat: If we merge 655 cold lead to a conflict

<gb> Pull Request 655 Tests t0112 and t0113 use 1.1-specific features (by gkellogg) [test:missing-coverage]

gkellogg: Shouldn't.
… Generally don't like to use merge commits.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compaction: t0112, t0113 in LD 1.0 processing mode
3 participants