Skip to content

Commit bae6baa

Browse files
committedApr 3, 2025··
Ensure resources and tools are removed even if some part of the operation fails
1 parent a1fe4e0 commit bae6baa

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed
 

‎servers/wanaku-server-quarkus/src/main/java/ai/wanaku/server/quarkus/api/v1/resources/ResourcesBean.java

+7-2
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,12 @@ private void doExposeResource(ResourceReference resourceReference) {
6464

6565
public void remove(String name) {
6666
ResourceReference resourceReference = resourceReferenceRepository.findById(name);
67-
resourceManager.removeResource(resourceReference.getLocation());
68-
resourceReferenceRepository.deleteById(resourceReference.getName());
67+
68+
try {
69+
resourceManager.removeResource(resourceReference.getLocation());
70+
} finally {
71+
resourceReferenceRepository.deleteById(resourceReference.getName());
72+
}
73+
6974
}
7075
}

‎servers/wanaku-server-quarkus/src/main/java/ai/wanaku/server/quarkus/api/v1/tools/ToolsBean.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,10 @@ void loadTools(@Observes StartupEvent ev) {
8787
}
8888

8989
public void remove(String name) {
90-
toolManager.removeTool(name);
91-
toolReferenceRepository.deleteById(name);
90+
try {
91+
toolManager.removeTool(name);
92+
} finally {
93+
toolReferenceRepository.deleteById(name);
94+
}
9295
}
9396
}

0 commit comments

Comments
 (0)
Please sign in to comment.