Fix FD getting code on big endian (php#17259)

* Fix FD getting code on big endian (PHP 8.3)

stream casting as FD returns a php_socket_t, which is an int, but
zend_long is 64-bit (on those platforms). This works on LE by
accidental (unless it forgets to clear the high word), but is fatal
on big endian.

* change cast to match sig

Author: NattyNarwhal

ext/posix/posix.c

@@ -15,13 +15,15 @@
  */
 
 #ifdef HAVE_CONFIG_H
-#include <config.h>
+#include "config.h"
 #endif
 
 #include "php.h"
 #include <unistd.h>
 #include "ext/standard/info.h"
+#include "ext/standard/php_string.h"
 #include "php_posix.h"
+#include "main/php_network.h"
 
 #ifdef HAVE_POSIX
 
@@ -38,9 +40,10 @@
 #include <errno.h>
 #include <grp.h>
 #include <pwd.h>
-#ifdef MAJOR_IN_MKDEV
+#ifdef HAVE_SYS_MKDEV_H
 # include <sys/mkdev.h>
-#elif defined(MAJOR_IN_SYSMACROS)
+#endif
+#ifdef HAVE_SYS_SYSMACROS_H
 # include <sys/sysmacros.h>
 #endif
 
@@ -356,7 +359,7 @@ PHP_FUNCTION(posix_uname)
 	add_assoc_string(return_value, "version",  u.version);
 	add_assoc_string(return_value, "machine",  u.machine);
 
-#if defined(_GNU_SOURCE) && defined(HAVE_STRUCT_UTSNAME_DOMAINNAME)
+#if defined(_GNU_SOURCE) && !defined(DARWIN) && defined(HAVE_UTSNAME_DOMAINNAME)
 	add_assoc_string(return_value, "domainname", u.domainname);
 #endif
 }
@@ -415,30 +418,32 @@ PHP_FUNCTION(posix_ctermid)
 /* }}} */
 
 /* Checks if the provides resource is a stream and if it provides a file descriptor */
-static zend_result php_posix_stream_get_fd(zval *zfp, zend_long *fd) /* {{{ */
+static int php_posix_stream_get_fd(zval *zfp, zend_long *ret) /* {{{ */
 {
 	php_stream *stream;
 
 	php_stream_from_zval_no_verify(stream, zfp);
 
 	if (stream == NULL) {
-		return FAILURE;
+		return 0;
 	}
 
-	/* get the fd.
+	/* get the fd. php_socket_t is used for FDs, and is shorter than zend_long.
 	 * NB: Most other code will NOT use the PHP_STREAM_CAST_INTERNAL flag when casting.
 	 * It is only used here so that the buffered data warning is not displayed.
 	 */
+	php_socket_t fd = -1;
 	if (php_stream_can_cast(stream, PHP_STREAM_AS_FD_FOR_SELECT | PHP_STREAM_CAST_INTERNAL) == SUCCESS) {
-		php_stream_cast(stream, PHP_STREAM_AS_FD_FOR_SELECT | PHP_STREAM_CAST_INTERNAL, (void*)fd, 0);
+		php_stream_cast(stream, PHP_STREAM_AS_FD_FOR_SELECT | PHP_STREAM_CAST_INTERNAL, (void**)&fd, 0);
 	} else if (php_stream_can_cast(stream, PHP_STREAM_AS_FD | PHP_STREAM_CAST_INTERNAL) == SUCCESS) {
-		php_stream_cast(stream, PHP_STREAM_AS_FD | PHP_STREAM_CAST_INTERNAL, (void*)fd, 0);
+		php_stream_cast(stream, PHP_STREAM_AS_FD | PHP_STREAM_CAST_INTERNAL, (void**)&fd, 0);
 	} else {
 		php_error_docref(NULL, E_WARNING, "Could not use stream of type '%s'",
 				stream->ops->label);
-		return FAILURE;
+		return 0;
 	}
-	return SUCCESS;
+	*ret = fd;
+	return 1;
 }
 /* }}} */
 
@@ -458,7 +463,7 @@ PHP_FUNCTION(posix_ttyname)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if (Z_TYPE_P(z_fd) == IS_RESOURCE) {
-		if (php_posix_stream_get_fd(z_fd, &fd) == FAILURE) {
+		if (!php_posix_stream_get_fd(z_fd, &fd)) {
 			RETURN_FALSE;
 		}
 	} else {
@@ -519,7 +524,7 @@ PHP_FUNCTION(posix_isatty)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if (Z_TYPE_P(z_fd) == IS_RESOURCE) {
-		if (php_posix_stream_get_fd(z_fd, &fd) == FAILURE) {
+		if (!php_posix_stream_get_fd(z_fd, &fd)) {
 			RETURN_FALSE;
 		}
 	} else {
@@ -532,13 +537,11 @@ PHP_FUNCTION(posix_isatty)
 
 	/* A valid file descriptor must fit in an int and be positive */
 	if (fd < 0 || fd > INT_MAX) {
-		POSIX_G(last_error) = EBADF;
 		RETURN_FALSE;
 	}
 	if (isatty(fd)) {
 		RETURN_TRUE;
 	} else {
-		POSIX_G(last_error) = errno;
 		RETURN_FALSE;
 	}
 }
@@ -632,7 +635,7 @@ PHP_FUNCTION(posix_mknod)
 			zend_argument_value_error(3, "cannot be 0 for the POSIX_S_IFCHR and POSIX_S_IFBLK modes");
 			RETURN_THROWS();
 		} else {
-#ifdef HAVE_MAKEDEV
+#if defined(HAVE_MAKEDEV) || defined(makedev)
 			php_dev = makedev(major, minor);
 #else
 			php_error_docref(NULL, E_WARNING, "Cannot create a block or character device, creating a normal file instead");
@@ -746,7 +749,7 @@ PHP_FUNCTION(posix_eaccess)
 
 	path = expand_filepath(filename, NULL);
 	if (!path) {
-		zend_argument_must_not_be_empty_error(1);
+		zend_argument_value_error(1, "cannot be empty");
 		RETURN_THROWS();
 	}
 
@@ -1043,7 +1046,7 @@ PHP_FUNCTION(posix_getpwuid)
 #define UNLIMITED_STRING "unlimited"
 
 /* {{{ posix_addlimit */
-static zend_result posix_addlimit(int limit, const char *name, zval *return_value) {
+static int posix_addlimit(int limit, const char *name, zval *return_value) {
 	int result;
 	struct rlimit rl;
 	char hard[80];
@@ -1285,7 +1288,7 @@ PHP_FUNCTION(posix_pathconf)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if (path_len == 0) {
-		zend_argument_must_not_be_empty_error(1);
+		zend_argument_value_error(1, "cannot be empty");
 		RETURN_THROWS();
 	} else if (php_check_open_basedir(path)) {
 		php_error_docref(NULL, E_WARNING, "Invalid path supplied: %s", path);
@@ -1315,7 +1318,7 @@ PHP_FUNCTION(posix_fpathconf)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if (Z_TYPE_P(z_fd) == IS_RESOURCE) {
-		if (php_posix_stream_get_fd(z_fd, &fd) == FAILURE) {
+		if (!php_posix_stream_get_fd(z_fd, &fd)) {
 			RETURN_FALSE;
 		}
 	} else {