feat: use ReferenceTracker

Author: waynzh

lib/rules/no-deprecated-delete-set.js

@@ -5,10 +5,22 @@
 'use strict'
 
 const utils = require('../utils')
-const { findVariable } = require('@eslint-community/eslint-utils')
+const { ReferenceTracker } = require('@eslint-community/eslint-utils')
 
+/**
+ * @typedef {import('@eslint-community/eslint-utils').TYPES.TraceMap} TraceMap
+ */
+
+/** @type {TraceMap} */
+const deletedImportApisMap = {
+  set: {
+    [ReferenceTracker.CALL]: true
+  },
+  del: {
+    [ReferenceTracker.CALL]: true
+  }
+}
 const deprecatedApis = new Set(['set', 'delete'])
-const deprecatedImportApis = new Set(['set', 'del'])
 const deprecatedDollarApis = new Set(['$set', '$delete'])
 
 /**
@@ -63,59 +75,6 @@ module.exports = {
         return identifier.parent.parent
       }
 
-      // Vue 3 Global API
-      if (
-        identifier.parent.type === 'CallExpression' &&
-        identifier.parent.callee === identifier
-      ) {
-        const variable = findVariable(
-          utils.getScope(context, identifier),
-          identifier
-        )
-
-        if (variable != null && variable.defs.length === 1) {
-          const def = variable.defs[0]
-
-          // import { set as st } from 'vue'; st()
-          if (
-            def.type === 'ImportBinding' &&
-            def.node.type === 'ImportSpecifier' &&
-            def.node.imported.type === 'Identifier' &&
-            deprecatedImportApis.has(def.node.imported.name) &&
-            def.node.parent.type === 'ImportDeclaration' &&
-            def.node.parent.source.value === 'vue'
-          ) {
-            return identifier.parent
-          }
-
-          // const { set, delete } = require('vue'); set()
-          if (
-            def.type === 'Variable' &&
-            def.node.type === 'VariableDeclarator' &&
-            def.node.id.type === 'ObjectPattern' &&
-            def.node.init?.type === 'CallExpression' &&
-            def.node.init.callee.type === 'Identifier' &&
-            def.node.init.callee.name === 'require' &&
-            def.node.init.arguments.length === 1 &&
-            def.node.init.arguments[0].type === 'Literal' &&
-            def.node.init.arguments[0].value === 'vue'
-          ) {
-            const properties = def.node.id.properties
-            for (const prop of properties) {
-              if (
-                prop.type === 'Property' &&
-                prop.key.type === 'Identifier' &&
-                deprecatedImportApis.has(prop.key.name) &&
-                prop.value.type === 'Identifier' &&
-                prop.value.name === identifier.name
-              ) {
-                return identifier.parent
-              }
-            }
-          }
-        }
-      }
-
       return undefined
     }
 
@@ -136,7 +95,44 @@ module.exports = {
 
     return utils.compositingVisitors(
       utils.defineVueVisitor(context, nodeVisitor),
-      utils.defineScriptSetupVisitor(context, nodeVisitor)
+      utils.defineScriptSetupVisitor(context, nodeVisitor),
+      {
+        /** @param {Program} node */
+        Program(node) {
+          const tracker = new ReferenceTracker(utils.getScope(context, node))
+
+          // import { set } from 'vue'; set()
+          const esmTraceMap = {
+            vue: {
+              [ReferenceTracker.ESM]: true,
+              ...deletedImportApisMap
+            }
+          }
+
+          for (const { node } of tracker.iterateEsmReferences(esmTraceMap)) {
+            const refNode = /** @type {CallExpression} */ (node)
+            context.report({
+              node: refNode.callee,
+              messageId: 'deprecated'
+            })
+          }
+
+          // const { set } = require('vue'); set()
+          const cjsTraceMap = {
+            vue: {
+              ...deletedImportApisMap
+            }
+          }
+
+          for (const { node } of tracker.iterateCjsReferences(cjsTraceMap)) {
+            const refNode = /** @type {CallExpression} */ (node)
+            context.report({
+              node: refNode.callee,
+              messageId: 'deprecated'
+            })
+          }
+        }
+      }
     )
   }
 }

tests/lib/rules/no-deprecated-delete-set.js

@@ -11,7 +11,10 @@ const tester = new RuleTester({
   languageOptions: {
     parser: require('vue-eslint-parser'),
     ecmaVersion: 2020,
-    sourceType: 'module'
+    sourceType: 'module',
+    globals: {
+      require: 'readonly'
+    }
   }
 })
 
@@ -350,6 +353,27 @@ tester.run('no-deprecated-delete-set', rule, {
           line: 6
         }
       ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <script setup>
+          const v = require('vue')
+
+          v.set(obj, key, value)
+          v.del(obj, key)
+        </script>
+      `,
+      errors: [
+        {
+          messageId: 'deprecated',
+          line: 5
+        },
+        {
+          messageId: 'deprecated',
+          line: 6
+        }
+      ]
     }
   ]
 })