Skip to content

Commit 91e2981

Browse files
xzhan96chromium-wpt-export-bot
authored andcommitted
Fix the issue of skip-waiting-installed.https.html
According to the current spec, skipWaiting() promise should be resolved earlier even in the case that the service worker state is "installed", and then continues the activate in parallel. The test case violate that. The background is in w3c/ServiceWorker#1015. BUG=725616 Change-Id: Ic09b4d404ea41138c8bda8d3ced07094a7ebc6ab Reviewed-on: https://chromium-review.googlesource.com/571612 Cr-Commit-Position: refs/heads/master@{#487024} WPT-Export-Revision: 2256ed61b315000c27f6c8b0dd94a3f025c4adc1
1 parent 2c5306a commit 91e2981

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

service-workers/service-worker/skip-waiting-installed.https.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@
2020
assert_equals(
2121
message, 'PASS',
2222
'skipWaiting promise should be resolved with undefined');
23-
24-
assert_equals(registration.active.scriptURL, normalizeURL(url2),
25-
'skipWaiting should make worker become active');
2623
});
2724
var saw_controllerchanged = new Promise(function(resolve) {
2825
oncontrollerchanged = function() {
2926
assert_equals(
3027
frame_sw.controller.scriptURL, normalizeURL(url2),
3128
'Controller scriptURL should change to the second one');
29+
30+
assert_equals(registration.active.scriptURL, normalizeURL(url2),
31+
'skipWaiting should make worker become active');
3232
resolve();
3333
};
3434
});

0 commit comments

Comments
 (0)