Merge pull request #2765 from ethereum/issue/2763

Setting of a provider after initiating a Web3 object without a provider fixed

Author: nivida

packages/web3-core/src/AbstractWeb3Module.js

@@ -289,7 +289,7 @@ export default class AbstractWeb3Module {
      */
     isSameProvider(provider) {
         if (isObject(provider)) {
-            if (this.currentProvider.constructor.name === provider.constructor.name) {
+            if (this.currentProvider && this.currentProvider.constructor.name === provider.constructor.name) {
                 return this.currentProvider.host === provider.host;
             }
 

packages/web3-core/tests/src/AbstractWeb3ModuleTest.js

@@ -125,6 +125,18 @@ describe('AbstractWeb3ModuleTest', () => {
         expect(abstractWeb3Module.setProvider('http://localhost:8545')).toEqual(false);
     });
 
+    it('calls isSameProvider without a currentProvider set and returns false', () => {
+        const provider = {
+            constructor: {
+                name: 'HttpProvider'
+            },
+            host: 'HOST1'
+        };
+
+        abstractWeb3Module.setProvider(false);
+        expect(abstractWeb3Module.isSameProvider(provider)).toEqual(false);
+    });
+
     it('calls isSameProvider and returns false', () => {
         const provider = {
             constructor: {