Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Commit 9b92aac

Browse files
authored
Merge pull request #3719 from ethereum/fix/issue-3717
Fix/issue 3717
2 parents f19481f + 79f074b commit 9b92aac

File tree

4 files changed

+14
-19
lines changed

4 files changed

+14
-19
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,3 +289,7 @@ Released with 1.0.0-beta.37 code base.
289289
## [Unreleased]
290290

291291
## [1.3.1]
292+
293+
### Removed
294+
295+
- Removed post-install script in `packages/web3`. Added documentation to root README (#3717)

README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,15 @@ If you are using the types in a `commonjs` module, like in a Node app, you just
101101
....
102102
```
103103
104+
## Trouble shooting and known issues.
105+
106+
### Web3 and Angular
107+
If you are using Ionic/Angular at a version >5 you may run into a build error in which modules `crypto` and `stream` are `undefined`
108+
109+
a work around for this is to go into your node-modules and at `/angular-cli-files/models/webpack-configs/browser.js` change the `node: false` to `node: {crypto: true, stream: true}` as mentioned [here](https://github.com/ethereum/web3.js/issues/2260#issuecomment-458519127)
110+
111+
Another variation of this problem was an issue opned on angular-cli: https://github.com/angular/angular-cli/issues/1548
112+
104113
## Documentation
105114
106115
Documentation can be found at [ReadTheDocs][docs].

packages/web3/angular-patch.js

Lines changed: 0 additions & 17 deletions
This file was deleted.

packages/web3/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@
2020
"types": "types/index.d.ts",
2121
"scripts": {
2222
"tsc": "tsc -b tsconfig.json",
23-
"dtslint": "dtslint --localTs ../../node_modules/typescript/lib types",
24-
"postinstall": "node angular-patch.js"
23+
"dtslint": "dtslint --localTs ../../node_modules/typescript/lib types"
2524
},
2625
"authors": [
2726
{

0 commit comments

Comments
 (0)