Merge branch '1.x' into patch-1

Author: kigawas

CHANGELOG.md

@@ -289,3 +289,7 @@ Released with 1.0.0-beta.37 code base.
 ## [Unreleased]
 
 ## [1.3.1]
+
+### Removed
+
+- Removed post-install script in `packages/web3`. Added documentation to root README (#3717)

README.md

@@ -101,6 +101,15 @@ If you are using the types in a `commonjs` module, like in a Node app, you just
     ....
 ```
 
+## Trouble shooting and known issues.
+
+### Web3 and Angular
+If you are using Ionic/Angular at a version >5 you may run into a build error in which modules `crypto` and `stream` are `undefined`
+
+a work around for this is to go into your node-modules and at `/angular-cli-files/models/webpack-configs/browser.js` change  the `node: false` to `node: {crypto: true, stream: true}` as mentioned [here](https://github.com/ethereum/web3.js/issues/2260#issuecomment-458519127)
+
+Another variation of this problem was an issue opned on angular-cli: https://github.com/angular/angular-cli/issues/1548
+
 ## Documentation
 
 Documentation can be found at [ReadTheDocs][docs].

packages/web3-core-requestmanager/src/index.js

@@ -91,7 +91,7 @@ RequestManager.prototype.setProvider = function (provider, net) {
 
 
     // reset the old one before changing, if still connected
-    if(this.provider && this.provider.connected)
+    if (this.provider && this.provider.connected)
         this.clearSubscriptions();
 
     this.provider = provider || null;
@@ -123,17 +123,17 @@ RequestManager.prototype.setProvider = function (provider, net) {
 
         // notify all subscriptions about bad close conditions
         this.provider.on('close', function close(event) {
-            if (!_this._isCleanCloseEvent(event) || _this._isIpcCloseError(event)){
+            if (!_this._isCleanCloseEvent(event) || _this._isIpcCloseError(event)) {
                 _this.subscriptions.forEach(function (subscription) {
                     subscription.callback(errors.ConnectionCloseError(event));
                     _this.subscriptions.delete(subscription.subscription.id);
                 });
 
-                if(_this.provider && _this.provider.emit){
+                if (_this.provider && _this.provider.emit) {
                     _this.provider.emit('error', errors.ConnectionCloseError(event));
                 }
             }
-            if(_this.provider && _this.provider.emit){
+            if (_this.provider && _this.provider.emit) {
                 _this.provider.emit('end', event);
             }
         });
@@ -151,7 +151,7 @@ RequestManager.prototype.setProvider = function (provider, net) {
  * @param {Function} callback
  */
 RequestManager.prototype.send = function (data, callback) {
-    callback = callback || function () {};
+    callback = callback || function () { };
 
     if (!this.provider) {
         return callback(errors.InvalidProvider());
@@ -163,7 +163,7 @@ RequestManager.prototype.send = function (data, callback) {
     const jsonrpcResultCallback = this._jsonrpcResultCallback(callback, jsonrpcPayload)
 
     if (this.provider.request) {
-        const callbackRequest = callbackify(this.provider.request)
+        const callbackRequest = callbackify(this.provider.request.bind(this.provider))
         const requestArgs = { method, params }
         callbackRequest(requestArgs, callback);
     } else if (this.provider.sendAsync) {
@@ -220,7 +220,7 @@ RequestManager.prototype.addSubscription = function (subscription, callback) {
             }
         );
     } else {
-        throw new Error('The provider doesn\'t support subscriptions: '+ this.provider.constructor.name);
+        throw new Error('The provider doesn\'t support subscriptions: ' + this.provider.constructor.name);
     }
 };
 
@@ -273,7 +273,7 @@ RequestManager.prototype.clearSubscriptions = function (keepIsSyncing) {
         }
 
         //  reset notification callbacks etc.
-        if(this.provider.reset)
+        if (this.provider.reset)
             this.provider.reset();
 
         return true
@@ -320,8 +320,8 @@ RequestManager.prototype._isIpcCloseError = function (event) {
  *
  */
 RequestManager.prototype._jsonrpcResultCallback = function (callback, payload) {
-    return function(err, result) { 
-        if(result && result.id && payload.id !== result.id) {
+    return function (err, result) {
+        if (result && result.id && payload.id !== result.id) {
             return callback(new Error(`Wrong response id ${result.id} (expected: ${payload.id}) in ${JSON.stringify(payload)}`));
         }
 

packages/web3/angular-patch.js

@@ -20,8 +20,7 @@
     "types": "types/index.d.ts",
     "scripts": {
         "tsc": "tsc -b tsconfig.json",
-        "dtslint": "dtslint --localTs ../../node_modules/typescript/lib types",
-        "postinstall": "node angular-patch.js"
+        "dtslint": "dtslint --localTs ../../node_modules/typescript/lib types"
     },
     "authors": [
         {