Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Make all communication async. #220

Closed
Georgi87 opened this issue May 25, 2015 · 8 comments
Closed

Make all communication async. #220

Georgi87 opened this issue May 25, 2015 · 8 comments
Labels
Enhancement Includes improvements or optimizations

Comments

@Georgi87
Copy link

I just adapted my application to work asynchronously using callbacks. The DAPP is way more responsive now. But it still lags sometimes. It could be due to the sha3 calls that are made for every request to get function signatures.

@Georgi87 Georgi87 reopened this May 27, 2015
@kumavis
Copy link
Contributor

kumavis commented May 27, 2015

web3 uses a lot of synchronous rpc calls internally for some reason. This has caused endless performance problems for me as well. If we can document the cases, it should be fairly easy to fix them.

@Georgi87
Copy link
Author

It seems to me that mostely the sha3 calls are responsible. Why not calculating the hash inside the browser or cache the results for function signatures as they don't change.

@frozeman
Copy link
Contributor

in develop sha3 is already an internal js function. not calling the RPC anymore

@frozeman frozeman added the Enhancement Includes improvements or optimizations label May 28, 2015
@frozeman
Copy link
Contributor

Actually newFilter, which we use internally is also not async.

@frozeman
Copy link
Contributor

frozeman commented Jun 4, 2015

Here is a list of functions, which need to be used async internally:

  • eth_newFilter
  • eth_uninstallFilter

@kumavis
Copy link
Contributor

kumavis commented Jun 6, 2015

@frozeman thanks for taking a look into this

@frozeman
Copy link
Contributor

frozeman commented Jun 6, 2015

fixed in #230

@kumavis
Copy link
Contributor

kumavis commented Jun 7, 2015

yay~

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

No branches or pull requests

3 participants