Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Inject commit hash into scripts/html/index.html for Surge E2E test #3471

Closed
cgewecke opened this issue Apr 15, 2020 · 0 comments · Fixed by #3476
Closed

Inject commit hash into scripts/html/index.html for Surge E2E test #3471

cgewecke opened this issue Apr 15, 2020 · 0 comments · Fixed by #3476
Assignees
@cgewecke
Labels
1.x 1.0 related issues

Comments

@cgewecke
Copy link
Collaborator

cgewecke commented Apr 15, 2020 •
edited
Loading

@ryanio noted while opening #3470 that there's no explicit guarantee in the Surge test that the site is serving the minified bundle from the CI build. We could be looking at a cached version for example.

Relevant env vars are:

  • TRAVIS_COMMIT
  • GITHUB_SHA (Github actions)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cgewecke cgewecke

Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark html file with commit & branch in surge e2e test web3/web3.js
1 participant
@cgewecke