You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 5, 2025. It is now read-only.
So one problem we have with upgrading dependencies is @ethereumjs/common and by extension, @ethereumjs/tx (since it depends on the former)
The problem: In this PR (specifically this commit) the typescript version is bumped from 3.x.x to 4.x.x. After this change, Web3.js starts to get the following tsc error when building web3-eth-accounts:
lerna ERR! npm run compile exited 1 in'web3-eth-accounts'
lerna ERR! npm run compile stdout:
>[email protected] compile
> tsc -b tsconfig.json
Error: ../../node_modules/@ethereumjs/common/dist/types.d.ts(38,32): error TS1005: ',' expected.
Error: ../../node_modules/@ethereumjs/common/dist/types.d.ts(38,58): error TS1005: ',' expected.
Error: ../../node_modules/@ethereumjs/common/dist/types.d.ts(40,12): error TS1005: ',' expected.
Error: ../../node_modules/@ethereumjs/common/dist/types.d.ts(41,9): error TS1005: ',' expected.
Error: ../../node_modules/@ethereumjs/common/dist/types.d.ts(42,12): error TS1005: ',' expected.
lerna ERR! npm run compile exited 1 in'web3-eth-accounts'
lerna WARN complete Waiting for 2 child processes to exit. CTRL-C to exit immediately.
Error: Process completed with exit code 1.
Currently in 1.x, the version 2.5.0 of @ethereumjs/common is being used (and version 3.3.2 of @ethereumjs/tx) which was released a year ago according to NPM:
PR #5529 updates some dependencies while locking @ethereumjs/common and @ethereumjs/tx to versions 2.5.0 and 3.3.2 respectively, and these errors are no longer received and all tests still pass
PR #5530 accepted to update typescript to ^4.8.4, but received many errors
The text was updated successfully, but these errors were encountered: