Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

1.x dependencies update #5422

Closed
4 tasks
jdevcs opened this issue Sep 8, 2022 · 2 comments · Fixed by #5529
Closed
4 tasks

1.x dependencies update #5422

jdevcs opened this issue Sep 8, 2022 · 2 comments · Fixed by #5529
Assignees
Labels
1.x 1.0 related issues

Comments

@jdevcs
Copy link
Contributor

jdevcs commented Sep 8, 2022

  • uuid
  • ethers
  • ethereumjs/libs
  • and discuss, list and update other libs that can be updated without any breaking changes
@jdevcs jdevcs added the 1.x 1.0 related issues label Sep 8, 2022
@jdevcs
Copy link
Contributor Author

jdevcs commented Sep 20, 2022

check if following required:

  • Bump terser from 4.8.0 to 4.8.1

@luu-alex luu-alex self-assigned this Oct 3, 2022
@luu-alex luu-alex removed their assignment Oct 12, 2022
@spacesailor24 spacesailor24 self-assigned this Oct 13, 2022
@spacesailor24
Copy link
Contributor

spacesailor24 commented Oct 13, 2022

So one problem we have with upgrading dependencies is @ethereumjs/common and by extension, @ethereumjs/tx (since it depends on the former)

The problem: In this PR (specifically this commit) the typescript version is bumped from 3.x.x to 4.x.x. After this change, Web3.js starts to get the following tsc error when building web3-eth-accounts:

lerna ERR! npm run compile exited 1 in 'web3-eth-accounts'
lerna ERR! npm run compile stdout:

> [email protected] compile
> tsc -b tsconfig.json

Error: ../../node_modules/@ethereumjs/common/dist/types.d.ts(38,32): error TS1005: ',' expected.
Error: ../../node_modules/@ethereumjs/common/dist/types.d.ts(38,58): error TS1005: ',' expected.
Error: ../../node_modules/@ethereumjs/common/dist/types.d.ts(40,12): error TS1005: ',' expected.
Error: ../../node_modules/@ethereumjs/common/dist/types.d.ts(41,9): error TS1005: ',' expected.
Error: ../../node_modules/@ethereumjs/common/dist/types.d.ts(42,12): error TS1005: ',' expected.
lerna ERR! npm run compile exited 1 in 'web3-eth-accounts'
lerna WARN complete Waiting for 2 child processes to exit. CTRL-C to exit immediately.
Error: Process completed with exit code 1.

Currently in 1.x, the version 2.5.0 of @ethereumjs/common is being used (and version 3.3.2 of @ethereumjs/tx) which was released a year ago according to NPM:

image

PR #5529 updates some dependencies while locking @ethereumjs/common and @ethereumjs/tx to versions 2.5.0 and 3.3.2 respectively, and these errors are no longer received and all tests still pass

PR #5530 accepted to update typescript to ^4.8.4, but received many errors

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants