Skip to content

Commit 2365685

Browse files
committedNov 12, 2024
adding in data-cy and fixing validation issue with checkbox/radio/switch
1 parent ce120ac commit 2365685

File tree

4 files changed

+10
-0
lines changed

4 files changed

+10
-0
lines changed
 

‎src/plugin/components/fields/CommonField/CommonField.vue

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
:is="component"
1313
v-model="modelValue"
1414
v-bind="boundSettings"
15+
:data-cy="`vsf-field-${field.name}`"
1516
:error="hasErrors"
1617
:error-messages="errorMessage || field.errorMessages"
1718
:items="fieldItems"

‎src/plugin/components/fields/VSFCheckbox/VSFCheckbox.vue

+4
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,14 @@
1212
<v-checkbox
1313
v-model="modelValue"
1414
v-bind="(boundSettings as Omit<Settings, 'validateOn'>)"
15+
:data-cy="`vsf-field-${field.name}`"
1516
:density="fieldDensity"
1617
:disabled="isValidating"
1718
:error="errorMessage ? errorMessage?.length > 0 : false"
1819
:error-messages="errorMessage"
1920
@blur="onActions(validate, 'blur')"
2021
@change="onActions(validate, 'change')"
22+
@click="fieldValidateOn === 'blur' || fieldValidateOn === 'change' ? onActions(validate, 'click') : undefined"
2123
@input="onActions(validate, 'input')"
2224
>
2325
<template #label>
@@ -80,6 +82,7 @@
8082
v-bind="(boundSettings as Omit<Settings, 'validateOn'>)"
8183
:id="option.id"
8284
v-model="modelValue"
85+
:data-cy="`vsf-field-${field.name}`"
8386
:density="fieldDensity"
8487
:disabled="isValidating"
8588
:error="errorMessage ? errorMessage?.length > 0 : false"
@@ -90,6 +93,7 @@
9093
:true-value="option.value"
9194
@blur="onActions(validate, 'blur')"
9295
@change="onActions(validate, 'change')"
96+
@click="fieldValidateOn === 'blur' || fieldValidateOn === 'change' ? onActions(validate, 'click') : undefined"
9397
@input="onActions(validate, 'input')"
9498
@update:focused="updateFocused($event)"
9599
/>

‎src/plugin/components/fields/VSFRadio/VSFRadio.vue

+3
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
<v-radio-group
3737
v-model="modelValue"
3838
:append-icon="field?.appendIcon"
39+
:data-cy="`vsf-field-group-${field.name}`"
3940
:density="fieldDensity"
4041
:direction="field?.direction"
4142
:disabled="isValidating"
@@ -61,6 +62,7 @@
6162
<v-radio
6263
v-bind="boundSettings"
6364
:id="undefined"
65+
:data-cy="`vsf-field-${field.name}`"
6466
:density="fieldDensity"
6567
:error="errorMessage ? errorMessage?.length > 0 : false"
6668
:error-messages="errorMessage"
@@ -70,6 +72,7 @@
7072
:value="option.value"
7173
@blur="onActions(validate, 'blur')"
7274
@change="onActions(validate, 'change')"
75+
@click="fieldValidateOn === 'blur' || fieldValidateOn === 'change' ? onActions(validate, 'click') : undefined"
7376
@input="onActions(validate, 'input')"
7477
>
7578
</v-radio>

‎src/plugin/components/fields/VSFSwitch/VSFSwitch.vue

+2
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,14 @@
1111
<v-switch
1212
v-bind="(boundSettings as Omit<Settings, 'validateOn'>)"
1313
v-model="modelValue"
14+
:data-cy="`vsf-field-${field.name}`"
1415
:density="fieldDensity"
1516
:disabled="isValidating"
1617
:error="errorMessage ? errorMessage?.length > 0 : false"
1718
:error-messages="errorMessage"
1819
@blur="onActions((validate as ValidateFieldResult), 'blur')"
1920
@change="onActions((validate as ValidateFieldResult), 'change')"
21+
@click="fieldValidateOn === 'blur' || fieldValidateOn === 'change' ? onActions(validate, 'click') : undefined"
2022
@input="onActions((validate as ValidateFieldResult), 'input')"
2123
>
2224
<template #label>

0 commit comments

Comments
 (0)
Please sign in to comment.