fix impl

Author: spawnia

src/Executor/ReferenceExecutor.php

@@ -1339,20 +1339,14 @@ protected function ensureValidRuntimeType(
             );
         }
 
-        if (!$this->exeContext->schema->getType($runtimeType->name)) {
-          throw new InvariantViolation(
-            sprintf(
-              'Schema does not contain the type named "%s". ' .
-              'Most often it happens when the object type is never referenced in fields directly ' .
-              'but is still a part of a schema because it implements an interface which resolves ' .
-              'to this object type in its resolveType callable. ' .
-              'List the type "%s" in option types if it cannot be detected by graphql-php during ' .
-              'static schema analysis. ' .
-              '(see https://webonyx.github.io/graphql-php/type-system/schema/#configuration-options).',
-              $runtimeType,
-              $runtimeType
-            )
-          );
+        if ($this->exeContext->schema->getType($runtimeType->name) === null) {
+            throw new InvariantViolation(
+                'Schema does not contain type "' . $runtimeType->name . '". ' .
+                'This can happen when an object type is only referenced indirectly through ' .
+                'abstract types and never directly through fields.' .
+                'List the type in the option "types" during schema construction, ' .
+                'see https://webonyx.github.io/graphql-php/type-system/schema/#configuration-options.'
+            );
         }
 
         if ($runtimeType !== $this->exeContext->schema->getType($runtimeType->name)) {

tests/Executor/AbstractTest.php

@@ -441,6 +441,66 @@ public function testReturningInvalidValueFromResolveTypeYieldsUsefulError(): voi
         self::assertEquals($expected, $result->toArray(DebugFlag::INCLUDE_DEBUG_MESSAGE));
     }
 
+    public function testWarnsAboutOrphanedTypesWhenMissingType(): void
+    {
+        $fooObject    = null;
+        $fooInterface = new InterfaceType([
+            'name'        => 'FooInterface',
+            'fields'      => [
+                'bar' => [
+                    'type' => Type::string(),
+                ],
+            ],
+            'resolveType' => static function () use (&$fooObject): ?ObjectType {
+                return $fooObject;
+            },
+        ]);
+
+        $fooObject = new ObjectType([
+            'name'       => 'FooObject',
+            'fields'     => [
+                'bar' => [
+                    'type' => Type::string(),
+                ],
+            ],
+            'interfaces' => [$fooInterface],
+        ]);
+
+        $schema = new Schema([
+            'query' => new ObjectType([
+                'name'   => 'Query',
+                'fields' => [
+                    'foo' => [
+                        'type'    => $fooInterface,
+                        'resolve' => static fn (): array => ['bar' => 'baz'],
+                    ],
+                ],
+            ]),
+        ]);
+
+        $result = GraphQL::executeQuery($schema, '{ foo { bar } }');
+
+        $expected = [
+            'data'   => ['foo' => null],
+            'errors' => [
+                [
+                    'message'      => 'Internal server error',
+                    'locations'    => [['line' => 1, 'column' => 3]],
+                    'path'         => ['foo'],
+                    'extensions' => [
+                        'debugMessage' =>
+                            'Schema does not contain type "FooObject". ' .
+                            'This can happen when an object type is only referenced indirectly through ' .
+                            'abstract types and never directly through fields.' .
+                            'List the type in the option "types" during schema construction, ' .
+                            'see https://webonyx.github.io/graphql-php/type-system/schema/#configuration-options.',
+                    ],
+                ],
+            ],
+        ];
+        self::assertEquals($expected, $result->toArray(DebugFlag::INCLUDE_DEBUG_MESSAGE));
+    }
+
     /**
      * @see it('resolveType allows resolving with type name')
      */