HMR doesn't update when there's an eslint error

[brigand]

When developing, I expect to see updates in the browser even when eslint errors. The weird thing is that if I refresh the page, I see the update. It's just hot module replacement that breaks. I see the eslint errors in the browser console and terminal.

I'm not passing any options to eslint-loader.

{ devtool: 'eval',
  entry:
   [ 'babel-polyfill',
     'webpack-dev-server/client?http://localhost:8081',
     'webpack/hot/only-dev-server',
     './src/client',
     './src/scss/core.scss' ],
  output:
   { path: '/home/fb/app/client/dist',
     publicPath: 'http://localhost:8081/public',
     filename: 'bundle.js' },
  devServer: { headers: { 'Access-Control-Allow-Origin': '*' } },
  externals: [],
  module:
   { rules:
      [ { test: /\.js$/,
          use: [ { loader: 'babel-loader' }, { loader: 'eslint-loader' } ],
          include:
           [ '/home/fb/app/client/src',
             '/home/fb/app/client/dev/dev-pages' ] },
        { test: /\.css$/,
          include: '/home/fb/app/client/assets/sprites',
          use:
           [ { loader: 'style-loader' },
             { loader: 'css-loader' },
             { loader: 'postcss-loader', query: { sourceMap: true } } ] },
        { test: /\.less$/,
          loaders:
           [ 'style-loader',
             'css-loader',
             { loader: 'postcss-loader', query: { sourceMap: true } },
             'less-loader' ],
          include:
           [ '/home/fb/app/client/src',
             '/home/fb/app/client/dev/dev-pages' ] },
        { test: /slick\.css$/,
          use: [ { loader: 'style-loader' }, { loader: 'css-loader' } ] },
        { test: /\.scss$/,
          loader:
           [ { loader: 'style-loader' },
             { loader: 'css-loader', options: { sourceMap: true } },
             { loader: 'postcss-loader', query: { sourceMap: true } },
             { loader: 'sass-loader',
               options:
                { sourceMap: true,
                  outputStyle: 'expanded',
                  includePaths: [ '/home/fb/app/client/node_modules/compass-mixins/lib' ] } } ] },
        { test: /\.rsvg$/,
          loaders: [ 'babel-loader', 'rsvg-loader' ],
          include:
           [ '/home/fb/app/client/src',
             '/home/fb/app/client/dev/dev-pages' ] },
        { test: /\.woff(\?v=\d+\.\d+\.\d+)?$/, loader: 'file-loader' },
        { test: /\.woff2(\?v=\d+\.\d+\.\d+)?$/, loader: 'file-loader' },
        { test: /\.ttf(\?v=\d+\.\d+\.\d+)?$/, loader: 'file-loader' },
        { test: /\.eot(\?v=\d+\.\d+\.\d+)?$/, loader: 'file-loader' },
        { test: /\.mp3(\?v=\d+\.\d+\.\d+)?$/, loader: 'file-loader' },
        { test: /\.svg(\?v=\d+\.\d+\.\d+)?$/, loader: 'file-loader' },
        { test: /\.png$/, loader: 'file-loader' },
        { test: /\.jpe?g$|\.gif$/, loader: 'file-loader' } ],
     noParse: [ /sql\.js$/ ] },
  resolveLoader:
   { modules:
      [ 'node_modules',
        '/home/fb/app/client/web_loaders' ] },
  plugins:
   [ DefinePlugin {
       definitions:
        { __DEV__: true,
          __PROD__: false,
          __USE_MOCKS__: false,
          __ASSET_URL__: '"http://localhost:8081/public"',
          __API_BASE_MACRO__: '""',
          __IMAGES_URL_BASE__: '"https://i.site.com/"',
          'process.env.NODE_ENV': '"development"' } },
     HotModuleReplacementPlugin {
       options: {},
       multiStep: undefined,
       fullBuildTimeout: 200,
       requestTimeout: 10000 },
     { options: {}, lastBuildSucceeded: false, isFirstBuild: true } ],
  node: { net: 'empty', dns: 'empty', tls: 'empty', fs: 'empty' } }

[MoOx]

Eslint errors are considered as webpack errors. Eslint warnings as webpack warnings. As explained in the README :)

You may have missed this section of the docs https://github.com/MoOx/eslint-loader#errors-and-warning

In short: you may want to use emitWarning to not trigger webpack build error.

[brigand]

Thanks for the response. I read that, but I didn't make the connection, especially with refreshing the page working. Added a note in #194.