Skip to content

Commit 23ea2cb

Browse files
committed
fix: review changes
1 parent 8e97331 commit 23ea2cb

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Diff for: src/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ class MiniCssExtractPlugin {
147147
);
148148
}
149149

150-
module.buildInfo = module.buildInfo || { assets: {} };
150+
module.buildInfo = module.buildInfo || {};
151151
module.buildInfo.assets = {
152152
...module.buildInfo.assets,
153153
...assets,

Diff for: src/loader.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export function pitch(request) {
7676
);
7777

7878
let source;
79-
let assets = {};
79+
const assets = {};
8080
childCompiler.hooks.afterCompile.tap(pluginName, (compilation) => {
8181
source =
8282
compilation.assets[childFilename] &&
@@ -85,7 +85,7 @@ export function pitch(request) {
8585
// Collect assets from modules
8686
compilation.modules.forEach((module) => {
8787
if (module.buildInfo && module.buildInfo.assets) {
88-
assets = { ...assets, ...module.buildInfo.assets };
88+
Object.assign(assets, module.buildInfo.assets);
8989
}
9090
});
9191

0 commit comments

Comments
 (0)