Skip to content

Commit 5889d43

Browse files
fix: source map url for devtool (only webpack@5) (#650)
1 parent 022d945 commit 5889d43

File tree

15 files changed

+52
-3
lines changed

15 files changed

+52
-3
lines changed

src/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import schema from './plugin-options.json';
1111
import { MODULE_TYPE, compareModulesByIdentifier } from './utils';
1212

1313
// webpack 5 exposes the sources property to ensure the right version of webpack-sources is used
14-
const { ConcatSource, SourceMapSource, OriginalSource } =
14+
const { ConcatSource, SourceMapSource, RawSource } =
1515
// eslint-disable-next-line global-require
1616
webpack.sources || require('webpack-sources');
1717

@@ -688,7 +688,7 @@ class MiniCssExtractPlugin {
688688
);
689689
} else {
690690
source.add(
691-
new OriginalSource(content, m.readableIdentifier(requestShortener))
691+
new RawSource(content, m.readableIdentifier(requestShortener))
692692
);
693693
}
694694
source.add('\n');

test/cases/devtool-source-map-from-loaders/expected/webpack-4/main.css.map

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/cases/devtool-source-map-from-loaders/expected/webpack-5/main.css

+6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/cases/devtool-source-map-from-loaders/expected/webpack-5/main.css.map

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
import Self from '../../../src';
2+
3+
module.exports = {
4+
entry: './index.js',
5+
devtool: 'source-map',
6+
module: {
7+
rules: [
8+
{
9+
test: /\.css$/,
10+
use: [
11+
Self.loader,
12+
{
13+
loader: 'css-loader',
14+
options: {
15+
sourceMap: true,
16+
},
17+
},
18+
],
19+
},
20+
],
21+
},
22+
plugins: [
23+
new Self({
24+
filename: '[name].css',
25+
}),
26+
],
27+
};

test/cases/devtool-source-map-no-source-maps-from-css-loader/expected/main.css.map

-1
This file was deleted.

test/cases/devtool-source-map-no-source-maps-from-loaders/expected/webpack-4/main.css

+6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/cases/devtool-source-map-no-source-maps-from-loaders/expected/webpack-4/main.css.map

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
body {
2+
background: red;
3+
}
4+
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import './style.css';
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
body {
2+
background: red;
3+
}

0 commit comments

Comments
 (0)