Skip to content

Commit 60c3eef

Browse files
fix: improved webpack version check (#638)
1 parent bd7e0ba commit 60c3eef

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/index.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable class-methods-use-this */
22

3-
import webpack, { version as webpackVersion } from 'webpack';
3+
import webpack from 'webpack';
44

55
import { validate } from 'schema-utils';
66

@@ -103,7 +103,9 @@ class MiniCssExtractPlugin {
103103

104104
/** @param {import("webpack").Compiler} compiler */
105105
apply(compiler) {
106-
const isWebpack4 = compiler.webpack ? false : webpackVersion[0] === '4';
106+
const isWebpack4 = compiler.webpack
107+
? false
108+
: typeof compiler.resolvers !== 'undefined';
107109

108110
if (!isWebpack4) {
109111
const { splitChunks } = compiler.options.optimization;

src/loader.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import path from 'path';
22

33
import loaderUtils from 'loader-utils';
4-
import { version as webpackVersion } from 'webpack';
54
import NodeTemplatePlugin from 'webpack/lib/node/NodeTemplatePlugin';
65
import NodeTargetPlugin from 'webpack/lib/node/NodeTargetPlugin';
76
import LibraryTemplatePlugin from 'webpack/lib/LibraryTemplatePlugin';
@@ -103,7 +102,9 @@ export function pitch(request) {
103102

104103
let source;
105104

106-
const isWebpack4 = childCompiler.webpack ? false : webpackVersion[0] === '4';
105+
const isWebpack4 = childCompiler.webpack
106+
? false
107+
: typeof childCompiler.resolvers !== 'undefined';
107108

108109
if (isWebpack4) {
109110
childCompiler.hooks.afterCompile.tap(pluginName, (compilation) => {

0 commit comments

Comments
 (0)