Skip to content

Commit 6292440

Browse files
VieZhongVieZhong
authored
fix: avoid to throw error when link doesn't have parentNode (#1016)
1 parent cab796f commit 6292440

File tree

11 files changed

+9
-9
lines changed

11 files changed

+9
-9
lines changed

‎src/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -862,7 +862,7 @@ class MiniCssExtractPlugin {
862862
'err.code = "CSS_CHUNK_LOAD_FAILED";',
863863
"err.type = errorType;",
864864
"err.request = realHref;",
865-
"linkTag.parentNode.removeChild(linkTag)",
865+
"if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)",
866866
"reject(err);",
867867
]),
868868
"}",

‎test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.4568ffdcdfced785eabc.css ‎test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.b1a0d51fa05593feebfa.css

File renamed without changes.

‎test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/4568ffdcdfced785eabc.css ‎test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/b1a0d51fa05593feebfa.css

File renamed without changes.

‎test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__);
7373
/******/
7474
/******/ /* webpack/runtime/getFullHash */
7575
/******/ (() => {
76-
/******/ __webpack_require__.h = () => ("4568ffdcdfced785eabc")
76+
/******/ __webpack_require__.h = () => ("b1a0d51fa05593feebfa")
7777
/******/ })();
7878
/******/
7979
/******/ /* webpack/runtime/global */
@@ -189,7 +189,7 @@ __webpack_require__.r(__webpack_exports__);
189189
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
190190
/******/ err.type = errorType;
191191
/******/ err.request = realHref;
192-
/******/ linkTag.parentNode.removeChild(linkTag)
192+
/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)
193193
/******/ reject(err);
194194
/******/ }
195195
/******/ }

‎test/cases/chunkFilename-fullhash/expected/webpack-5/0.9ee2d65d5d13f2b4323d.css ‎test/cases/chunkFilename-fullhash/expected/webpack-5/0.775d09b0a3e56e73fd45.css

File renamed without changes.

‎test/cases/chunkFilename-fullhash/expected/webpack-5/9ee2d65d5d13f2b4323d.css ‎test/cases/chunkFilename-fullhash/expected/webpack-5/775d09b0a3e56e73fd45.css

File renamed without changes.

‎test/cases/chunkFilename-fullhash/expected/webpack-5/main.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__);
7373
/******/
7474
/******/ /* webpack/runtime/getFullHash */
7575
/******/ (() => {
76-
/******/ __webpack_require__.h = () => ("9ee2d65d5d13f2b4323d")
76+
/******/ __webpack_require__.h = () => ("775d09b0a3e56e73fd45")
7777
/******/ })();
7878
/******/
7979
/******/ /* webpack/runtime/global */
@@ -189,7 +189,7 @@ __webpack_require__.r(__webpack_exports__);
189189
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
190190
/******/ err.type = errorType;
191191
/******/ err.request = realHref;
192-
/******/ linkTag.parentNode.removeChild(linkTag)
192+
/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)
193193
/******/ reject(err);
194194
/******/ }
195195
/******/ }

‎test/cases/hmr/expected/main.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -952,7 +952,7 @@ __webpack_require__.r(__webpack_exports__);
952952
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
953953
/******/ err.type = errorType;
954954
/******/ err.request = realHref;
955-
/******/ linkTag.parentNode.removeChild(linkTag)
955+
/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)
956956
/******/ reject(err);
957957
/******/ }
958958
/******/ }

‎test/cases/insert-function/expected/main.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@
173173
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
174174
/******/ err.type = errorType;
175175
/******/ err.request = realHref;
176-
/******/ linkTag.parentNode.removeChild(linkTag)
176+
/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)
177177
/******/ reject(err);
178178
/******/ }
179179
/******/ }

‎test/cases/insert-string/expected/main.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@
173173
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
174174
/******/ err.type = errorType;
175175
/******/ err.request = realHref;
176-
/******/ linkTag.parentNode.removeChild(linkTag)
176+
/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)
177177
/******/ reject(err);
178178
/******/ }
179179
/******/ }

‎test/cases/insert-undefined/expected/main.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@
173173
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
174174
/******/ err.type = errorType;
175175
/******/ err.request = realHref;
176-
/******/ linkTag.parentNode.removeChild(linkTag)
176+
/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)
177177
/******/ reject(err);
178178
/******/ }
179179
/******/ }

0 commit comments

Comments
 (0)