Skip to content

Commit 70ce174

Browse files
fix: bloated runtime (#687)
1 parent 05e2951 commit 70ce174

File tree

7 files changed

+14
-14
lines changed

7 files changed

+14
-14
lines changed

Diff for: src/index.js

+8-3
Original file line numberDiff line numberDiff line change
@@ -477,10 +477,15 @@ class MiniCssExtractPlugin {
477477
MODULE_TYPE,
478478
'mini-css',
479479
`${webpack.RuntimeGlobals.require}.miniCssF`,
480-
(referencedChunk) =>
481-
referencedChunk.canBeInitial()
480+
(referencedChunk) => {
481+
if (!referencedChunk.contentHash[MODULE_TYPE]) {
482+
return false;
483+
}
484+
485+
return referencedChunk.canBeInitial()
482486
? this.options.filename
483-
: this.options.chunkFilename,
487+
: this.options.chunkFilename;
488+
},
484489
true
485490
)
486491
);

Diff for: test/cases/hmr/expected/webpack-5/main.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ module.exports = function (urlString) {
358358
/******/ // This function allow to reference all chunks
359359
/******/ __webpack_require__.miniCssF = (chunkId) => {
360360
/******/ // return url for filenames based on template
361-
/******/ return "" + "main" + ".css";
361+
/******/ return undefined;
362362
/******/ };
363363
/******/ })();
364364
/******/

Diff for: test/cases/hmr/webpack.config.js

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import Self from '../../../src';
44

55
module.exports = {
66
entry: './index.css',
7+
mode: 'development',
78
module: {
89
rules: [
910
{

Diff for: test/cases/insert-function/expected/webpack-5/main.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,8 @@
5454
/******/ (() => {
5555
/******/ // This function allow to reference all chunks
5656
/******/ __webpack_require__.miniCssF = (chunkId) => {
57-
/******/ // return url for filenames not based on template
58-
/******/ if (chunkId === 1) return "1.css";
5957
/******/ // return url for filenames based on template
60-
/******/ return "" + "main" + ".css";
58+
/******/ return "" + chunkId + ".css";
6159
/******/ };
6260
/******/ })();
6361
/******/

Diff for: test/cases/insert-string/expected/webpack-5/main.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,8 @@
5454
/******/ (() => {
5555
/******/ // This function allow to reference all chunks
5656
/******/ __webpack_require__.miniCssF = (chunkId) => {
57-
/******/ // return url for filenames not based on template
58-
/******/ if (chunkId === 1) return "1.css";
5957
/******/ // return url for filenames based on template
60-
/******/ return "" + "main" + ".css";
58+
/******/ return "" + chunkId + ".css";
6159
/******/ };
6260
/******/ })();
6361
/******/

Diff for: test/cases/insert-undefined/expected/webpack-5/main.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,8 @@
5454
/******/ (() => {
5555
/******/ // This function allow to reference all chunks
5656
/******/ __webpack_require__.miniCssF = (chunkId) => {
57-
/******/ // return url for filenames not based on template
58-
/******/ if (chunkId === 1) return "1.css";
5957
/******/ // return url for filenames based on template
60-
/******/ return "" + "main" + ".css";
58+
/******/ return "" + chunkId + ".css";
6159
/******/ };
6260
/******/ })();
6361
/******/

Diff for: test/cases/runtime/expected/webpack-5/runtime~main.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@
101101
/******/ // This function allow to reference all chunks
102102
/******/ __webpack_require__.miniCssF = (chunkId) => {
103103
/******/ // return url for filenames based on template
104-
/******/ return "" + ({"0":"main","1":"runtime~main"}[chunkId] || chunkId) + "." + {"0":"a7263f8f763dcf4051bc"}[chunkId] + ".css";
104+
/******/ return "" + "main" + "." + "a7263f8f763dcf4051bc" + ".css";
105105
/******/ };
106106
/******/ })();
107107
/******/

0 commit comments

Comments
 (0)