changed __UglifyJsPlugin to use WeakSet

hulkish · hulkish · commit 19c203b504ea · 2017-06-29T03:45:28.000-04:00
diff --git a/src/index.js b/src/index.js
@@ -50,14 +50,14 @@ class UglifyJsPlugin {
         // eslint-disable-next-line prefer-spread
         files.push.apply(files, compilation.additionalChunkAssets);
         const filteredFiles = files.filter(ModuleFilenameHelpers.matchObject.bind(undefined, options));
+        const uglifiedAssets = new WeakSet();
         filteredFiles.forEach((file) => {
           const oldWarnFunction = uglify.AST_Node.warn_function;
           const warnings = [];
           let sourceMap;
           try {
             const asset = compilation.assets[file];
-            if (asset.__UglifyJsPlugin) {
-              compilation.assets[file] = asset.__UglifyJsPlugin;
+            if (uglifiedAssets.has(asset)) {
               return;
             }
             let input;
@@ -220,9 +220,7 @@ class UglifyJsPlugin {
                 }
               }
             }
-            compilation.assets[file] = outputSource;
-            asset.__UglifyJsPlugin = outputSource;
-
+            uglifiedAssets.add(compilation.assets[file] = outputSource);
             if (warnings.length > 0) {
               compilation.warnings.push(new Error(`${file} from UglifyJs\n${warnings.join('\n')}`));
             }

Original file line number	Diff line number	Diff line change
`@@ -50,14 +50,14 @@ class UglifyJsPlugin {`
`50`	`50`	`// eslint-disable-next-line prefer-spread`
`51`	`51`	`files.push.apply(files, compilation.additionalChunkAssets);`
`52`	`52`	`const filteredFiles = files.filter(ModuleFilenameHelpers.matchObject.bind(undefined, options));`
	`53`	`+ const uglifiedAssets = new WeakSet();`
`53`	`54`	`filteredFiles.forEach((file) => {`
`54`	`55`	`const oldWarnFunction = uglify.AST_Node.warn_function;`
`55`	`56`	`const warnings = [];`
`56`	`57`	`let sourceMap;`
`57`	`58`	`try {`
`58`	`59`	`const asset = compilation.assets[file];`
`59`		`- if (asset.__UglifyJsPlugin) {`
`60`		`- compilation.assets[file] = asset.__UglifyJsPlugin;`
	`60`	`+ if (uglifiedAssets.has(asset)) {`
`61`	`61`	`return;`
`62`	`62`	`}`
`63`	`63`	`let input;`
`@@ -220,9 +220,7 @@ class UglifyJsPlugin {`
`220`	`220`	`}`
`221`	`221`	`}`
`222`	`222`	`}`
`223`		`- compilation.assets[file] = outputSource;`
`224`		`- asset.__UglifyJsPlugin = outputSource;`
`225`		`-`
	`223`	`+ uglifiedAssets.add(compilation.assets[file] = outputSource);`
`226`	`224`	`if (warnings.length > 0) {`
`227`	`225`	compilation.warnings.push(new Error(`${file} from UglifyJs\n${warnings.join('\n')}`));
`228`	`226`	`}`