addressing PR comments

Author: grawk

lib/Shared.js

@@ -1,6 +1,7 @@
 var parseRange = require("range-parser");
 var pathIsAbsolute = require("path-is-absolute");
 var MemoryFileSystem = require("memory-fs");
+var HASH_REGEXP = /[0-9a-f]{10,}/;
 
 module.exports = function Shared(context) {
 	var share = {
@@ -49,6 +50,7 @@ module.exports = function Shared(context) {
 			}
 		},
 		handleRangeHeaders: function handleRangeHeaders(content, req, res) {
+			//assumes express API. For other servers, need to add logic to access alternative header APIs
 			res.setHeader("Accept-Ranges", "bytes");
 			if(req.headers.range) {
 				var ranges = parseRange(content.length, req.headers.range);
@@ -165,6 +167,21 @@ module.exports = function Shared(context) {
 				context.forceRebuild = true;
 			}
 		},
+		handleRequest: function(filename, processRequest, req) {
+			// in lazy mode, rebuild on bundle request
+			if(context.options.lazy && (!context.options.filename || context.options.filename.test(filename)))
+				share.rebuild();
+			if(HASH_REGEXP.test(filename)) {
+				try {
+					if(context.fs.statSync(filename).isFile()) {
+						processRequest();
+						return;
+					}
+				} catch(e) {
+				}
+			}
+			share.ready(processRequest, req);
+		},
 		waitUntilValid: function(callback) {
 			callback = callback || function() {};
 			share.ready(callback, {});

middleware.js

@@ -7,9 +7,6 @@ var getFilenameFromUrl = require("./lib/GetFilenameFromUrl");
 var Shared = require("./lib/Shared");
 var pathJoin = require("./lib/PathJoin");
 
-var HASH_REGEXP = /[0-9a-f]{10,}/;
-
-
 // constructor for the middleware
 module.exports = function(compiler, options) {
 
@@ -42,21 +39,8 @@ module.exports = function(compiler, options) {
 		var filename = getFilenameFromUrl(context.options.publicPath, context.compiler.outputPath, req.url);
 		if(filename === false) return goNext();
 
-		// in lazy mode, rebuild on bundle request
-		if(context.options.lazy && (!context.options.filename || context.options.filename.test(filename)))
-			shared.rebuild();
 
-		if(HASH_REGEXP.test(filename)) {
-			try {
-				if(context.fs.statSync(filename).isFile()) {
-					processRequest();
-					return;
-				}
-			} catch(e) {
-			}
-		}
-		// delay the request until we have a valid bundle
-		shared.ready(processRequest, req);
+		shared.handleRequest(filename, processRequest, req);
 
 		function processRequest() {
 			try {