Skip to content

Expose stats to let user know if there's any error during the compilation #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
egoist opened this issue Sep 19, 2016 · 2 comments
Closed

Expose stats to let user know if there's any error during the compilation #126

egoist opened this issue Sep 19, 2016 · 2 comments
Labels
priority: 4 (nice to have)

Comments

@egoist
Copy link
Contributor

egoist commented Sep 19, 2016

https://github.com/webpack/webpack-dev-middleware/blob/master/middleware.js#L89

// update to:
cb(stats);

// user could check errors with:
devMiddleWare.waitUntilValid(stats => {
  if (stats.hasError()) {} // blah blah...
})
@SpaceK33z
Copy link
Member

PR welcome.

@egoist egoist mentioned this issue Sep 19, 2016
Merged
@SpaceK33z
Copy link
Member

Fixed in #127.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: 4 (nice to have)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SpaceK33z @egoist