Skip to content

Commit 4c6103b

Browse files
authored
fix: typo in SSL information log (#3939)
* fix: typo in SSL information log * test: update snapshots
1 parent 0153c69 commit 4c6103b

7 files changed

+22
-12
lines changed

lib/Server.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,7 @@ class Server {
589589
const del = require("del");
590590

591591
this.logger.info(
592-
"SSL Certificate is more than 30 days old. Removing..."
592+
"SSL certificate is more than 30 days old. Removing..."
593593
);
594594

595595
await del([certificatePath], { force: true });
@@ -599,7 +599,7 @@ class Server {
599599
}
600600

601601
if (!certificateExists) {
602-
this.logger.info("Generating SSL Certificate...");
602+
this.logger.info("Generating SSL certificate...");
603603

604604
const selfsigned = require("selfsigned");
605605
const attributes = [{ name: "commonName", value: "localhost" }];

test/cli/__snapshots__/bonjour-option.test.js.snap.webpack4

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

33
exports[`"bonjour" CLI option should work using "--bonjour and --https" 1`] = `
4-
"<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
4+
"<i> [webpack-dev-server] Generating SSL certificate...
5+
<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
56
<i> [webpack-dev-server] Project is running at:
67
<i> [webpack-dev-server] Loopback: https://localhost:<port>/
78
<i> [webpack-dev-server] On Your Network (IPv4): https://<ip-v4>:<port>/

test/cli/__snapshots__/bonjour-option.test.js.snap.webpack5

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

33
exports[`"bonjour" CLI option should work using "--bonjour and --https" 1`] = `
4-
"<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
4+
"<i> [webpack-dev-server] Generating SSL certificate...
5+
<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
56
<i> [webpack-dev-server] Project is running at:
67
<i> [webpack-dev-server] Loopback: https://localhost:<port>/
78
<i> [webpack-dev-server] On Your Network (IPv4): https://<ip-v4>:<port>/

test/cli/__snapshots__/http2-option.test.js.snap.webpack4

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

33
exports[`"http2" CLI option should work using "--http2" 1`] = `
4-
"<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
4+
"<i> [webpack-dev-server] Generating SSL certificate...
5+
<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
56
<i> [webpack-dev-server] Project is running at:
67
<i> [webpack-dev-server] Loopback: https://localhost:<port>/
78
<i> [webpack-dev-server] On Your Network (IPv4): https://<ip-v4>:<port>/

test/cli/__snapshots__/http2-option.test.js.snap.webpack5

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

33
exports[`"http2" CLI option should work using "--http2" 1`] = `
4-
"<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
4+
"<i> [webpack-dev-server] Generating SSL certificate...
5+
<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
56
<i> [webpack-dev-server] Project is running at:
67
<i> [webpack-dev-server] Loopback: https://localhost:<port>/
78
<i> [webpack-dev-server] On Your Network (IPv4): https://<ip-v4>:<port>/

test/cli/__snapshots__/https-option.test.js.snap.webpack4

+6-3
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ exports[`"https" CLI option should warn using "--https-cacert" and "--https-ca"
1010
`;
1111

1212
exports[`"https" CLI option should work using "--https" 1`] = `
13-
"<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
13+
"<i> [webpack-dev-server] Generating SSL certificate...
14+
<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
1415
<i> [webpack-dev-server] Project is running at:
1516
<i> [webpack-dev-server] Loopback: https://localhost:<port>/
1617
<i> [webpack-dev-server] On Your Network (IPv4): https://<ip-v4>:<port>/
@@ -51,7 +52,8 @@ exports[`"https" CLI option should work using "--https-key-reset --https-key <pa
5152
`;
5253

5354
exports[`"https" CLI option should work using "--https-request-cert" 1`] = `
54-
"<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
55+
"<i> [webpack-dev-server] Generating SSL certificate...
56+
<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
5557
<i> [webpack-dev-server] Project is running at:
5658
<i> [webpack-dev-server] Loopback: https://localhost:<port>/
5759
<i> [webpack-dev-server] On Your Network (IPv4): https://<ip-v4>:<port>/
@@ -68,7 +70,8 @@ exports[`"https" CLI option should work using "--no-https" 1`] = `
6870
`;
6971

7072
exports[`"https" CLI option should work using "--no-https-request-cert" 1`] = `
71-
"<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
73+
"<i> [webpack-dev-server] Generating SSL certificate...
74+
<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
7275
<i> [webpack-dev-server] Project is running at:
7376
<i> [webpack-dev-server] Loopback: https://localhost:<port>/
7477
<i> [webpack-dev-server] On Your Network (IPv4): https://<ip-v4>:<port>/

test/cli/__snapshots__/https-option.test.js.snap.webpack5

+6-3
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ exports[`"https" CLI option should warn using "--https-cacert" and "--https-ca"
1010
`;
1111

1212
exports[`"https" CLI option should work using "--https" 1`] = `
13-
"<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
13+
"<i> [webpack-dev-server] Generating SSL certificate...
14+
<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
1415
<i> [webpack-dev-server] Project is running at:
1516
<i> [webpack-dev-server] Loopback: https://localhost:<port>/
1617
<i> [webpack-dev-server] On Your Network (IPv4): https://<ip-v4>:<port>/
@@ -51,7 +52,8 @@ exports[`"https" CLI option should work using "--https-key-reset --https-key <pa
5152
`;
5253

5354
exports[`"https" CLI option should work using "--https-request-cert" 1`] = `
54-
"<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
55+
"<i> [webpack-dev-server] Generating SSL certificate...
56+
<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
5557
<i> [webpack-dev-server] Project is running at:
5658
<i> [webpack-dev-server] Loopback: https://localhost:<port>/
5759
<i> [webpack-dev-server] On Your Network (IPv4): https://<ip-v4>:<port>/
@@ -68,7 +70,8 @@ exports[`"https" CLI option should work using "--no-https" 1`] = `
6870
`;
6971

7072
exports[`"https" CLI option should work using "--no-https-request-cert" 1`] = `
71-
"<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
73+
"<i> [webpack-dev-server] Generating SSL certificate...
74+
<i> [webpack-dev-server] SSL certificate: <cwd>/node_modules/.cache/webpack-dev-server/server.pem
7275
<i> [webpack-dev-server] Project is running at:
7376
<i> [webpack-dev-server] Loopback: https://localhost:<port>/
7477
<i> [webpack-dev-server] On Your Network (IPv4): https://<ip-v4>:<port>/

0 commit comments

Comments
 (0)