Skip to content

Commit 6ee8cd0

Browse files
authored
ci: add Node.js v24 (#5492)
1 parent d30f963 commit 6ee8cd0

8 files changed

+141
-496
lines changed

.github/workflows/nodejs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969
strategy:
7070
matrix:
7171
os: [ubuntu-latest, windows-latest, macos-latest]
72-
node-version: [18.x, 20.x, 22.x, 23.x]
72+
node-version: [18.x, 20.x, 22.x, 24.x]
7373
shard: ["1/4", "2/4", "3/4", "4/4"]
7474
webpack-version: [latest]
7575

test/cli/server-option.test.js

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -46,19 +46,24 @@ describe('"server" CLI options', () => {
4646
).toMatchSnapshot();
4747
});
4848

49-
it('should work using "--server-type spdy"', async () => {
50-
const { exitCode, stderr } = await testBin([
51-
"--port",
52-
port,
53-
"--server-type",
54-
"spdy",
55-
]);
56-
57-
expect(exitCode).toEqual(0);
58-
expect(
59-
normalizeStderr(stderr, { ipv6: true, https: true }),
60-
).toMatchSnapshot();
61-
});
49+
const [major] = process.versions.node.split(".").map(Number);
50+
51+
(major >= 24 ? it.skip : it)(
52+
'should work using "--server-type spdy"',
53+
async () => {
54+
const { exitCode, stderr } = await testBin([
55+
"--port",
56+
port,
57+
"--server-type",
58+
"spdy",
59+
]);
60+
61+
expect(exitCode).toEqual(0);
62+
expect(
63+
normalizeStderr(stderr, { ipv6: true, https: true }),
64+
).toMatchSnapshot();
65+
},
66+
);
6267

6368
it('should work using "--server-options-key <path> --server-options-pfx <path> --server-options-passphrase webpack-dev-server --server-options-cert <path>"', async () => {
6469
const pfxFile = path.join(httpsCertificateDirectory, "server.pfx");

test/e2e/__snapshots__/app.test.js.snap.webpack5

Lines changed: 0 additions & 309 deletions
This file was deleted.

0 commit comments

Comments
 (0)