Skip to content

Commit 82eda54

Browse files
committed
fix: use cli specific description for --open-app-name and --web-socket-server
1 parent b8ddf9f commit 82eda54

File tree

6 files changed

+163
-237
lines changed

6 files changed

+163
-237
lines changed

lib/options.json

+7-2
Original file line numberDiff line numberDiff line change
@@ -581,7 +581,10 @@
581581
{
582582
"type": "string",
583583
"minLength": 1,
584-
"description": "Open specified browser. Deprecated: please use '--open-app-name'."
584+
"description": "Open specified browser.",
585+
"cli": {
586+
"description": "Open specified browser. Deprecated: please use '--open-app-name'."
587+
}
585588
}
586589
],
587590
"description": "Open specified browser."
@@ -1043,7 +1046,9 @@
10431046
"$ref": "#/definitions/WebSocketServerType"
10441047
}
10451048
],
1046-
"description": "Deprecated: please use '--web-socket-server-type' option."
1049+
"cli": {
1050+
"description": "Deprecated: please use '--web-socket-server-type' option."
1051+
}
10471052
},
10481053
"WebSocketServerFunction": {
10491054
"instanceof": "Function"

package-lock.json

+15-15
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@
113113
"tcp-port-used": "^1.0.2",
114114
"typescript": "^4.2.4",
115115
"url-loader": "^4.1.1",
116-
"webpack": "^5.64.0",
116+
"webpack": "^5.67.0",
117117
"webpack-cli": "^4.7.2",
118118
"webpack-merge": "^5.8.0"
119119
},

test/__snapshots__/validate-options.test.js.snap.webpack4

+1-3
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@ exports[`options validate should throw an error on the "open" option with '{"app
521521
* options.open.app should be an object:
522522
object { name?, arguments? }
523523
* options.open.app should be a non-empty string.
524-
-> Open specified browser. Deprecated: please use '--open-app-name'."
524+
-> Open specified browser."
525525
`;
526526

527527
exports[`options validate should throw an error on the "open" option with '{"foo":"bar"}' value 1`] = `
@@ -929,7 +929,6 @@ exports[`options validate should throw an error on the "webSocketServer" option
929929
Details:
930930
* options.webSocketServer should be one of these:
931931
false | \\"sockjs\\" | \\"ws\\"
932-
-> Deprecated: please use '--web-socket-server-type' option.
933932
Details:
934933
* options.webSocketServer should be false.
935934
* options.webSocketServer should be one of these:
@@ -949,7 +948,6 @@ exports[`options validate should throw an error on the "webSocketServer" option
949948
Details:
950949
* options.webSocketServer should be one of these:
951950
false | \\"sockjs\\" | \\"ws\\"
952-
-> Deprecated: please use '--web-socket-server-type' option.
953951
Details:
954952
* options.webSocketServer should be false.
955953
* options.webSocketServer should be one of these:

test/__snapshots__/validate-options.test.js.snap.webpack5

+1-3
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@ exports[`options validate should throw an error on the "open" option with '{"app
521521
* options.open.app should be an object:
522522
object { name?, arguments? }
523523
* options.open.app should be a non-empty string.
524-
-> Open specified browser. Deprecated: please use '--open-app-name'."
524+
-> Open specified browser."
525525
`;
526526

527527
exports[`options validate should throw an error on the "open" option with '{"foo":"bar"}' value 1`] = `
@@ -929,7 +929,6 @@ exports[`options validate should throw an error on the "webSocketServer" option
929929
Details:
930930
* options.webSocketServer should be one of these:
931931
false | \\"sockjs\\" | \\"ws\\"
932-
-> Deprecated: please use '--web-socket-server-type' option.
933932
Details:
934933
* options.webSocketServer should be false.
935934
* options.webSocketServer should be one of these:
@@ -949,7 +948,6 @@ exports[`options validate should throw an error on the "webSocketServer" option
949948
Details:
950949
* options.webSocketServer should be one of these:
951950
false | \\"sockjs\\" | \\"ws\\"
952-
-> Deprecated: please use '--web-socket-server-type' option.
953951
Details:
954952
* options.webSocketServer should be false.
955953
* options.webSocketServer should be one of these:

0 commit comments

Comments
 (0)